Commit Graph

6 Commits

Author SHA1 Message Date
Javi Martín
2b962f2789 Use a <main> tag on every page
Many pages had this tag, but many other didn't, which made navigation
inconsistent for people using screen readers.

Note that there are slight changes in two pages:

* The homepage now includes the banner and the content of the
  `shared/header` element inside the <main> tag
* The budgets index now includes the banner inside the <main> tag

I see both potential advantages and disadvantages of this approach,
since banners aren't necessarily related to the main content of a page
but on the other hand they aren't the same across pages and people using
screen readers might accidentally skip them if they jump to the <main>
tag.

So I'm choosing the option that is easier to implement.

Note we're adding a `public-content` class to the <main> element in the
application layout. This might be redundat because the element could
already be accessed through the `.public main` selector, but this is
consistent with the `admin-content` class used in the admin section, and
without it the <main> element would sometimes have an empty class
attribute and we'd have to use `if content_for?(:main_class)` or
`tag.main` which IMHO makes the code less consistent.

The Capybara::DSL monkey-patch is only done on the `visit` method
because it's the only reliable one. Other methods like `click_link`
generate AJAX requests, so `expect(page).to have_css "main", count: 1`
might be executed before the AJAX request is finished, meaning it
wouldn't properly test anything.
2024-03-23 00:35:43 +01:00
Alberto Garcia Cabeza
5cf9a98e6a adds lang attribute on error pages 2017-03-06 13:38:40 +01:00
rgarcia
ac6b75e8f9 updates image url for error pages 2016-10-04 18:38:10 +02:00
Alberto Garcia Cabeza
c8fb73fe8f Adds background image for errors page 2015-09-08 14:46:58 +02:00
Alberto Garcia Cabeza
d1b84b7398 Adds 404 and 500 error pages 2015-09-05 00:30:11 +02:00
rgarcia
8db3630837 initial commit 2015-07-15 13:32:13 +02:00