consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11,202 Commits 1 Branch 0 Tags
0affaaee7e194d901b0ebc1bbb032444e12ec01e
Commit Graph

2271 Commits

Author SHA1 Message Date
Bertocq
2c3d8e9fd5 Avoid creating a budget in drafting phase to test results access 2018-01-09 01:16:09 +01:00
Bertocq
beee890285 Login as admin before visiting drafting budget on spec 2018-01-09 00:34:16 +01:00
Bertocq
0f5999fb8d Move admin creation into shared let on spec 2018-01-09 00:33:55 +01:00
María Checa
d8a6bb0f91 Changed tests 2018-01-09 00:09:50 +01:00
María Checa
5161988844 Removed external_url input 2018-01-08 23:22:46 +01:00
Bertocq
63694b5bae Increase admin budget feature spec for drafting phase 2018-01-08 22:52:56 +01:00
Bertocq
2026f537e6 Add drafting phase scenario to budget feature spec for list & show checks 2018-01-08 22:51:01 +01:00
Bertocq
506293fc80 Move level two user creation to a shared let on budget feature 2018-01-08 19:59:14 +01:00
Bertocq
377a514128 Refactor commmon budget creation to a shared one at budget feature spec 2018-01-08 19:40:27 +01:00
Bertocq
53842ba919 Add Update scenario to admin budget feature spec 2018-01-08 18:46:50 +01:00
Bertocq
51e3d75c62 Add destroy scenario to budget section of admin panel 2018-01-08 17:48:06 +01:00
Bertocq
16eae689f9 Enable RSpec/RepeatedExample cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample
 2018-01-07 18:46:32 +01:00
Bertocq
4f6597b200 Enable RSpec/RepeatedDescription cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription
 2018-01-07 17:45:34 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
c4aa2d7093 Enable RSpec/MessageExpectation cop & fix issues 
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
 2018-01-07 16:36:18 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 2018-01-07 16:23:49 +01:00
Bertocq
3e5b13ae4d Enable RSpec/LetBeforeExamples cop & fix issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
 2018-01-07 02:28:06 +01:00
Bertocq
eaf66e3ec1 Enable RSpec/IteratedExpectation cop and fix issues 
Suggested refactor is only available for `.to` and not for `.not_to` :(

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
 2018-01-07 02:24:24 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
97c5490995 Fix unnecesary spacing 2018-01-07 01:58:45 +01:00
Bertocq
f6aed3f9f1 Enable RSpec/ExpectActual cop and fix all issues 
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
 2018-01-07 01:55:38 +01:00
Bertocq
fa017b664f Enables RSpec/EmptyLineAfterFinalLet cop & fixes all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterFinalLet
 2018-01-07 00:49:37 +01:00
Bertocq
7f14544f71 Enable Capybara/CurrentPathExpectation cop & fix issues 
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule

On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
 2018-01-06 23:31:41 +01:00
Bertocq
2105e985a8 Fix budget investment random order feature to generate just enough elements for pagination 2018-01-06 18:21:24 +01:00
Bertocq
e8570ed7bb Fix spec link upcase to downcase for archived proposals 2018-01-03 18:03:05 +01:00
Bertocq
bf9ea64088 Fix spec link upcase to downcase for archived proposals 2018-01-03 17:37:55 +01:00
iagirre
64aaa97d86 Add feature specs to check that edit links and "Selected" buttons are not displayed/enabled. 
"Selected" button appears as text instead of dissapearing completely.
 2017-12-27 16:23:21 +01:00
María Checa
4192860a73 Added and improved related content tests 2017-12-18 23:56:44 +01:00
María Checa
0fd2b869ce Added tests 2017-12-18 18:22:01 +01:00
Bertocq
c2b5083d4f Fix missing and extra spacing 2017-12-16 17:59:16 +01:00
Alberto García
cec48c72ef Merge pull request #2195 from consul/milestones_improvements 
Make Milestones description required, hide title usage
 2017-12-15 18:47:30 +01:00
Bertocq
91e14f22e8 Update milestone feature specs to reflect default title value changes 2017-12-15 18:22:05 +01:00
María Checa
5f4b179f3e Added tests 2017-12-15 17:32:18 +01:00
Raimond Garcia
d0b407d4e5 Merge pull request #2183 from consul/related-content 
Related contents functionalities
 2017-12-15 10:00:43 +01:00
Raimond Garcia
9ba8ca7de3 Merge pull request #2187 from consul/notifications 
Fix notifications' exceptions
 2017-12-14 22:11:27 +01:00
María Checa
784e576f42 Added new tests 2017-12-14 21:03:23 +01:00
Alberto García
1737f85398 Merge branch 'master' into aperez-dates-for-milestones 2017-12-14 20:50:55 +01:00
Alberto García
09b544774d Merge pull request #2191 from wairbut-m2c/iagirre-add-documents-to-milestones 
Add documents to milestones
 2017-12-14 20:49:19 +01:00
rgarcia
2b52d26d82 refactors notifications into concerns and shared examples 2017-12-14 16:15:30 +01:00
BertoCQ
50b4f50eac Merge branch 'master' into aperez-dates-for-milestones 2017-12-14 15:42:35 +01:00
María Checa
7629fd2499 Added specs for related content form 2017-12-14 14:50:47 +01:00
Alberto García
45de7efd7a Merge pull request #1904 from consul/community-design 
Community design
 2017-12-14 14:44:03 +01:00
iagirre
ff50dc1a00 Add feature specs to test new admin features and documents' show in users view 2017-12-14 13:53:03 +01:00
Bertocq
a71ad644c5 Fix community topics specs 2017-12-14 13:51:10 +01:00
Alberto García
19925de06b Merge pull request #2170 from consul/design 
Design improvements
 2017-12-14 11:31:31 +01:00
Angel Perez
1e1028dcb4 Adapt existing milestone-related specs to fit the new requirement 2017-12-13 20:17:54 -04:00
iagirre
59a4b93a00 Add I18n texts for milestone images. 
Add specs to test admin image uploader and milestones' show.
Modify the UI to fit the mockups provided in the issue.
 2017-12-13 14:03:46 +01:00
María Checa
d6fd83915d Added tests for related contents list 2017-12-13 13:32:18 +01:00
Raimond Garcia
d49a1dc208 Merge pull request #2172 from consul/notifications 
Notifications for hidden resources
 2017-12-12 16:26:37 +01:00
rgarcia
e3c8dece8f Makes the code aware of notifications for hidden commentables 2017-12-11 13:22:10 +01:00