Commit Graph

281 Commits

Author SHA1 Message Date
rgarcia
8a669b86bd Fix English grammar in translations 2018-01-18 21:09:21 +01:00
Bertocq
808c4eddfc Fix budget investment feature spec 2018-01-18 18:59:57 +01:00
Bertocq
e4e9a149b0 Update expectations after decreasing end date of budget phase 2018-01-18 17:18:05 +01:00
decabeza
b48fb7a41e adds specs 2018-01-18 17:18:05 +01:00
Bertocq
a6b06ca730 Improve Budget's homepage
* Add budget's phases number status
* Add budget's headings and groups list
* Placeholders for future improvements
2018-01-17 19:11:58 +01:00
Bertocq
2fb1112066 Replace existing Time.zone.today.to_date for just Date.current 2018-01-17 00:45:30 +01:00
Bertocq
ca3d759d9f Refactor Budget publishing prices phases constant to Budget::Phase model 2018-01-16 12:18:13 +01:00
Bertocq
66691b644a Refactor Budget::PHASES constant to Budget::Phase::PHASE_KINDS 2018-01-16 12:18:13 +01:00
BertoCQ
3d5bf04829 Merge pull request #2311 from consul/2299-budget_investments_related_content
Budget investments related content
2018-01-15 20:02:34 +01:00
BertoCQ
61f52b3483 Merge pull request #2293 from wairbut-m2c/aperez-fix-deprecation-warnings
Fix for test suite deprecations warnings
2018-01-15 18:23:42 +01:00
María Checa
b2054ac531 Improved relationable tests for budget investments 2018-01-12 18:26:37 +01:00
decabeza
40d32f3e16 Merge branch 'master' into budgets-ui 2018-01-11 17:05:28 +01:00
Bertocq
2f27a86034 Replace deprecated capybara only_path option for ignore_query 2018-01-11 00:07:56 +01:00
decabeza
3b6fa6cbb4 fixes specs 2018-01-10 11:36:33 +01:00
Bertocq
f350b99123 Remove deprecated investment test scenario for price explanation 2018-01-10 01:04:32 +01:00
Bertocq
1d6c3034cb Add test scenarios to check investment price showing rules 2018-01-10 01:04:31 +01:00
María Checa
96859190be Merge pull request #2280 from consul/2277-budgets_new_form
Budgets new form
2018-01-09 11:55:10 +01:00
Bertocq
2c3d8e9fd5 Avoid creating a budget in drafting phase to test results access 2018-01-09 01:16:09 +01:00
María Checa
d8a6bb0f91 Changed tests 2018-01-09 00:09:50 +01:00
Bertocq
2026f537e6 Add drafting phase scenario to budget feature spec for list & show checks 2018-01-08 22:51:01 +01:00
Bertocq
506293fc80 Move level two user creation to a shared let on budget feature 2018-01-08 19:59:14 +01:00
Bertocq
377a514128 Refactor commmon budget creation to a shared one at budget feature spec 2018-01-08 19:40:27 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
2018-01-07 16:23:49 +01:00
Bertocq
3e5b13ae4d Enable RSpec/LetBeforeExamples cop & fix issues
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
2018-01-07 02:28:06 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
2018-01-07 02:07:19 +01:00
Bertocq
f6aed3f9f1 Enable RSpec/ExpectActual cop and fix all issues
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
2018-01-07 01:55:38 +01:00
Bertocq
7f14544f71 Enable Capybara/CurrentPathExpectation cop & fix issues
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule

On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
2018-01-06 23:31:41 +01:00
Bertocq
2105e985a8 Fix budget investment random order feature to generate just enough elements for pagination 2018-01-06 18:21:24 +01:00
Bertocq
91e14f22e8 Update milestone feature specs to reflect default title value changes 2017-12-15 18:22:05 +01:00
Raimond Garcia
9ba8ca7de3 Merge pull request #2187 from consul/notifications
Fix notifications' exceptions
2017-12-14 22:11:27 +01:00
Alberto García
1737f85398 Merge branch 'master' into aperez-dates-for-milestones 2017-12-14 20:50:55 +01:00
Alberto García
09b544774d Merge pull request #2191 from wairbut-m2c/iagirre-add-documents-to-milestones
Add documents to milestones
2017-12-14 20:49:19 +01:00
rgarcia
2b52d26d82 refactors notifications into concerns and shared examples 2017-12-14 16:15:30 +01:00
BertoCQ
50b4f50eac Merge branch 'master' into aperez-dates-for-milestones 2017-12-14 15:42:35 +01:00
iagirre
ff50dc1a00 Add feature specs to test new admin features and documents' show in users view 2017-12-14 13:53:03 +01:00
Alberto García
19925de06b Merge pull request #2170 from consul/design
Design improvements
2017-12-14 11:31:31 +01:00
Angel Perez
1e1028dcb4 Adapt existing milestone-related specs to fit the new requirement 2017-12-13 20:17:54 -04:00
iagirre
59a4b93a00 Add I18n texts for milestone images.
Add specs to test admin image uploader and milestones' show.
Modify the UI to fit the mockups provided in the issue.
2017-12-13 14:03:46 +01:00
decabeza
1d6877b797 adds setting allow_images to specs 2017-12-06 20:59:34 +01:00
iagirre
d118566234 Test changed to check the order when navigating through pages 2017-11-15 12:49:21 +01:00
iagirre
87f6f14d48 Bigger random seed range. Tests added to check the randomness between browsers 2017-11-15 11:50:06 +01:00
iagirre
f3527b1311 Test added to check the repetition of elements between pages when random order used. Scope variable initialized to 1 2017-11-15 09:01:35 +01:00
taitus
a0603985ef Refactor. 2017-09-27 14:51:35 +02:00
taitus
51c53b6f31 Add missing specs from Maps on New, Edit and Show. 2017-09-27 14:50:54 +02:00
Senén Rodero Rodríguez
ce29185b76 Fix documentable on admin poll questions. Adapt nested documentable shared specs to admin fetaure specs and include at admin poll questions specs. 2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
826385f659 Extract ajax upload and destroy_upload actions from images and documents controllers and place them at new controllers to manage direct uploads 2017-09-26 13:55:28 +02:00
Senén Rodero Rodríguez
16692c933e Move specs from imageable shared feature spec to proposals and budget investments path. 2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
ceabd16d57 Refactor. Create index scope inside imageable shared examples to check index action of any imageable model. Add image to proposals index. 2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
3310089208 Add nested imageable shared spec to check nested images behavior at imageable any recipients. 2017-09-26 13:55:03 +02:00