Bertocq
4e0d88739d
Fix Rails/Blank rubocop issue
2017-07-10 23:02:27 +02:00
BertoCQ
6285ad3b68
Merge pull request #1738 from consul/feature/improve_budget_results
...
Improve budget results
2017-07-10 22:57:30 +02:00
Bertocq
11a793d63f
Hide incompatible and non-winner investments by default
2017-07-10 19:43:55 +02:00
Bertocq
49f48ddf4b
Highlight current heading on results list
2017-07-10 17:48:04 +02:00
Bertocq
741a342bb0
Restrict compatilibility edit on admin investment form
...
Why:
* A non-winner but compatible investment shouldn't be marked as incompatible
How:
* Show incompatilibility checkbox only if investment is winner or incompatible
2017-07-10 17:34:05 +02:00
Bertocq
2fba9de33b
Don't display incompatible investment's table if empty
2017-07-10 17:12:28 +02:00
Bertocq
3a94fe4cc2
Fix indentation on if-else assignement
2017-07-10 16:03:31 +02:00
Bertocq
efacd0def3
Make calculate_winners explicitly delayed
...
Why:
* As seen on preproduction and production environments on Madrid's fork. Budget::Result#calculate_winners is very costly when done to all headings for a given budget (as requested on Admin::BudgetsController#calculate_winners) but its not when done individually for only a heading (as requested on Budget::Investment#recalculate_heading_winners)
How:
* Removing `handle_asynchronously :calculate_winners` from bellow Budget::Result#calculate_winners definition, to avoid making any call delayed. And explicitly calling `.delay` only when needed (on Admin::BudgetsController#calculate_winners)
2017-07-10 15:12:14 +02:00
Bertocq
2b85deabec
Recalculate heading winners on incompatibility change
...
Why:
* We should recalculate winners also when an incompatible investment is flagged as compatible again
How:
* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
2017-07-10 14:24:55 +02:00
Raimond Garcia
08bc32defb
Merge pull request #1728 from consul/rubocop/metrics_line_lenght
...
Rubocop 🤖 The LineLength Truncation ⚡ ️
2017-07-10 14:21:27 +02:00
Raimond Garcia
885d5edc3d
Merge pull request #1730 from consul/chore/gemfile_cleanup
...
Gemfile cleanup
2017-07-10 14:21:16 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
Bertocq
8f97bd86b7
Specify version for all gems
2017-07-10 12:52:04 +02:00
Senén Rodero Rodríguez
95630d6546
Add comment to temporary bugfix.
2017-07-10 12:46:31 +02:00
María Checa
089c690b49
Created new entry point CensusCaller
...
Here's a better alternative than the first one. Added a new abstraction level from which are performed both types of census calls, while the logic of those is managed in their own library.
2017-07-10 12:22:30 +02:00
Bertocq
3f9d95f6a3
Sort all gems in Gemfile
2017-07-10 12:18:49 +02:00
Bertocq
862a30b493
Remove unnecesary comments on gemfile
2017-07-10 12:05:34 +02:00
Bertocq
100926162e
Remove therubyracer gem, never used
2017-07-10 12:05:34 +02:00
Bertocq
efa2e7c774
Remove bcrypt gem, never used
2017-07-10 12:05:34 +02:00
Bertocq
5763ee03f4
Sort gem names alphabetically for dev and test groups
2017-07-10 12:05:34 +02:00
Bertocq
4e4f316f94
Reorganize development and test gems
2017-07-10 12:05:34 +02:00
Raimond Garcia
6fc5b1e8c9
Merge pull request #1735 from consul/chore/upgrade_initialjs-rails
...
Upgrade initialjs-rails gem
2017-07-10 12:03:21 +02:00
Raimond Garcia
81ac2581fb
Merge pull request #1734 from consul/fix/localize_date
...
Fix date localization
2017-07-10 12:02:07 +02:00
Raimond Garcia
debb12f026
Merge pull request #1733 from consul/chore/update_code_of_conduct
...
Update Code of Conduct
2017-07-10 12:01:09 +02:00
Raimond Garcia
cd91608922
Merge pull request #1729 from consul/chore/remove_tolk
...
Remove Tolk, Crowdin in use
2017-07-10 11:51:59 +02:00
Bertocq
74e2c406d4
Upgrade initialjs-rails gem version
...
In order to avoid some html validations a PR was opened https://github.com/dgilperez/initialjs-rails/pull/6 and later on merged with some extra specs coverage https://github.com/dgilperez/initialjs-rails/pull/7 Thanks @dgilperez and @decabeza!!
2017-07-10 01:01:32 +02:00
Bertocq
51a22e8733
Fix english translation string for figcaption
2017-07-09 17:07:56 +02:00
Bertocq
824a672292
Fix spectations for localized milestone date
2017-07-09 16:44:34 +02:00
Bertocq
b1caefdf9a
Use i18n to localize date on view
2017-07-09 13:44:31 +02:00
Bertocq
0b967dac89
Fix english translation for budget investment share
2017-07-09 13:37:15 +02:00
Bertocq
dd8ff5284f
Update Code of Conduct to contributor covenant 1.4
2017-07-09 13:06:44 +02:00
Bertocq
3dd459f18a
Fix valuation english translation to English
2017-07-09 11:59:51 +02:00
Bertocq
8b2b21c6d7
Remove Tolk, Crowdin substituted it
...
Why:
* Crowdin now hosts all consul translations publicly so anyone can contribute https://crowdin.com/project/consul/invite
* Crowdin makes easy for non-tech people to contribute, once we have a demo site we'll be able to offer "on site" translation
* If you still use Tolk, we recommend removing this commit (but adding tolk gem to ./Gemfile_custom file to avoid future merge conflicts)
How:
* Reverting changes introduced with 9610a6a933
2017-07-09 00:56:14 +02:00
María Checa
7e701db608
Added new census data source to Verification::Residence
...
Adapted model to perform a query to find a `LocalCensusRecord` record in case the census API is not available or returns invalid data.
2017-07-08 20:39:05 +02:00
María Checa
feff9fff0f
LocalCensus model created
2017-07-08 19:56:10 +02:00
Bertocq
dbc3af917a
Update rubocop_todo list with rubocop --auto-gen-config
2017-07-07 21:24:45 +02:00
Senén Rodero Rodríguez
112e0649bf
Add missing proposal model specs to check new users_to_notify method.
2017-07-07 15:18:37 +02:00
Senén Rodero Rodríguez
4b2310c135
Move and refactor method from follow to user model to get user interests. Add specification to check the discard of duplicate interests.
2017-07-07 15:18:34 +02:00
Senén Rodero Rodríguez
a7aef0a9fb
Initialize App js modules after followable update.
2017-07-07 13:38:53 +02:00
taitus
60e812c2e5
New texts and titles for followable buttons.
2017-07-07 13:38:53 +02:00
taitus
e54e33f296
Use display in followable shared specs names when referring to DOM elements renderization. Add whitespace to proposal page.
2017-07-07 13:38:53 +02:00
taitus
5fe894aa6b
New proposal method to get users_to_notify.
2017-07-07 13:38:52 +02:00
taitus
0c2be6a0d4
Refactor js followable response.
2017-07-07 13:38:52 +02:00
taitus
b60748c552
Remove unneeded return from Follow model. Add whitespaces to enhance reading.
2017-07-07 13:38:52 +02:00
taitus
97ee107157
Do not show flaggable and followable buttons on budgets_investment and proposals pages when user is not logged.
2017-07-07 13:38:52 +02:00
taitus
0ffa213a65
Fix scss-lint
2017-07-07 13:38:49 +02:00
taitus
b29bf62f56
Send proposals notifications to followers.
2017-07-07 13:37:55 +02:00
taitus
35f7f11177
Add dependent destroy to followable.
2017-07-07 13:37:55 +02:00
taitus
14ec4f5315
Add styles and translations for users interests.
2017-07-07 13:37:53 +02:00
Senén Rodero Rodríguez
313b78978d
Add followable JS module. Refactor follow_helper and follow buttons partial.
2017-07-07 13:34:54 +02:00
