Bertocq
900d8a00b1
Make milestone's description a required attribute
2017-12-15 16:38:21 +01:00
Raimond Garcia
9ba8ca7de3
Merge pull request #2187 from consul/notifications
...
Fix notifications' exceptions
2017-12-14 22:11:27 +01:00
Alberto García
1737f85398
Merge branch 'master' into aperez-dates-for-milestones
2017-12-14 20:50:55 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
iagirre
01a8c55936
Make Budget::Investment::Milestone class Documentable.
...
Add fields to the milestone form so that the admin can attach 0, 1 or multiple documents.
Add column to milestone list with a link to documents (if there is any).
Make documents accessible from the milestone view for users.
2017-12-14 10:53:01 +01:00
Angel Perez
6d57d76071
Admins can add a 'publication date' to milestones
2017-12-13 20:17:54 -04:00
iagirre
35986ea6b5
Budget::Investment::Milestone is imageable
...
Admin form attaches an image
Milestone list has a column "Image", empty or with a link to the image
2017-12-13 08:59:36 +01:00
Bertocq
13f5fa55ab
Use Relationable concern on Debates, Proposals and Budget Investments
2017-11-29 19:01:12 +01:00
Bertocq
c5fa85e3f6
Prevent a division by zero from happening on sort by random investment scope
2017-11-29 11:40:10 +01:00
María Checa
3984d6a947
Merge pull request #2115 from wairbut-m2c/iagirre-heading-population-restriction-validation
...
Iagirre heading population restriction validation
2017-11-28 20:06:53 +01:00
iagirre
f3527b1311
Test added to check the repetition of elements between pages when random order used. Scope variable initialized to 1
2017-11-15 09:01:35 +01:00
iagirre
7f0e447e0f
One aproach to make the randomness work with kaminari
2017-11-15 08:56:31 +01:00
iagirre
bfcbb6c0ad
Validation in model and in form added. When users makes the on focus on population field an explanation appears. Some specs added to test the model validations
2017-10-31 13:04:30 +01:00
taitus
a0603985ef
Refactor.
2017-09-27 14:51:35 +02:00
Senén Rodero Rodríguez
130e4533ac
Allow to render map without marker on new forms.
2017-09-27 14:48:12 +02:00
Senén Rodero Rodríguez
5956207a00
Add map locations. Each map location can belongs to proposal or budget investment.
2017-09-27 14:48:12 +02:00
Senén Rodero Rodríguez
88a7a29d27
Remove new_nested action from documents controller. Use cocoon gem to manage new nested fields creation on documents.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
6f71da07ee
Duplicate documentable code and rename for imageable
2017-09-26 13:55:03 +02:00
Bertocq
614ff79ba1
WIP
2017-09-26 13:53:43 +02:00
Bertocq
886431b43d
Revert changes in Budget::Investment model that added image attachment directly
2017-09-26 13:53:43 +02:00
Senén Rodero Rodríguez
f23fd927d6
Add constant to set minimum size for budget investment image.
2017-09-26 13:53:43 +02:00
Senén Rodero Rodríguez
c914c772c0
Add budget investment image dimmensions validator.
2017-09-26 13:53:42 +02:00
Alessandro Cuoghi
dd1e73c5fd
Add image into investment show and add some change of css.
2017-09-26 13:53:42 +02:00
Alessandro Cuoghi
aa471974bd
Use different image versions on responsive sizes
2017-09-26 13:53:42 +02:00
Senén Rodero Rodríguez
515d6d7e70
Rename image_description column to image_title on budget investments.
2017-09-26 13:53:42 +02:00
Senén Rodero Rodríguez
673fc66011
Add budget investements images specs
2017-09-26 13:53:42 +02:00
Senén Rodero Rodríguez
c399692109
Add image description to budget investments
2017-09-26 13:53:42 +02:00
Senén Rodero Rodríguez
00a8f42797
Added image content type validation to only allowing jpg images.
2017-09-26 13:53:42 +02:00
taitus
c5bb6dca65
Add image to budget investments.
2017-09-26 13:53:42 +02:00
Senén Rodero Rodríguez
4f5a552486
Added image content type validation to only allowing jpg images.
2017-09-26 13:53:42 +02:00
taitus
7b88e63136
Add image to budget investments.
2017-09-26 13:53:42 +02:00
taitus
74958b461a
Add new model concern Communitable with relation, callback and associate community.
2017-09-05 12:54:32 +02:00
taitus
895c942a39
Add community to investments
2017-09-05 12:52:45 +02:00
Senén Rodero Rodríguez
4081dded5f
Add nested documents to new budgetinvestments.
2017-08-25 18:34:53 +02:00
Senén Rodero Rodríguez
38d4d59241
Add arguments to documentable concern to make it configurable for any recipient model.
2017-08-25 17:27:37 +02:00
Senén Rodero Rodríguez
6b61cbe35c
Set maximum number of documents on proposal and budget investments. Show alert on documents tab when maximum reached. Hide upload button when maximum reached.
2017-08-25 17:27:37 +02:00
Senén Rodero Rodríguez
a2130689ed
Create documentable concern and add it to budget investment model. Create documents controller, documents helper, routes, translations and specs
2017-08-25 17:27:37 +02:00
BertoCQ
204ea13c85
Merge branch 'master' into followable
2017-07-11 11:30:49 +02:00
Bertocq
efacd0def3
Make calculate_winners explicitly delayed
...
Why:
* As seen on preproduction and production environments on Madrid's fork. Budget::Result#calculate_winners is very costly when done to all headings for a given budget (as requested on Admin::BudgetsController#calculate_winners) but its not when done individually for only a heading (as requested on Budget::Investment#recalculate_heading_winners)
How:
* Removing `handle_asynchronously :calculate_winners` from bellow Budget::Result#calculate_winners definition, to avoid making any call delayed. And explicitly calling `.delay` only when needed (on Admin::BudgetsController#calculate_winners)
2017-07-10 15:12:14 +02:00
Bertocq
2b85deabec
Recalculate heading winners on incompatibility change
...
Why:
* We should recalculate winners also when an incompatible investment is flagged as compatible again
How:
* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
2017-07-10 14:24:55 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
taitus
bce28afe36
Add followable to budget investment model.
2017-07-07 12:07:25 +02:00
BertoCQ
e990568895
Merge pull request #1721 from consul/feature/add_slugs_to_budget_related
...
Add slugs to budget related
2017-07-05 13:16:24 +02:00
Bertocq
e3d89261a6
Add Sluggable concern and unique validation to Budget, Group and Heading
...
* What: We need to generate slug on Budget, Group and Heading classes, validating its unique for its scope
* How: Adding a presence and unique validation using Budget always as scope.
2017-07-05 12:33:16 +02:00
Bertocq
2888c20489
Fix all Style/RedundantSelf rubocop issues
2017-07-05 11:55:52 +02:00
Bertocq
339597483e
Add incompatible scope to Budget Investment model
2017-07-04 01:34:25 +02:00
Bertocq
99052485fb
Recalculate heading winner investments when a winner is flagged as incompatible
2017-07-04 01:34:24 +02:00
Bertocq
640e0e1c2a
Use compatible filter when calculating budget heading winners
2017-07-04 01:34:24 +02:00
Bertocq
ed016d7afd
Add compatible scope to Budget Investment and use it on the winners scope
...
Why:
* Only compatible investments can be winners
How:
* Using the new column incompatible to filter compatible investments
2017-07-04 01:34:24 +02:00
Bertocq
c9bc028524
Remove all unnecesary extra spacing and Layout/ExtraSpacing list from rubocop file
2017-06-28 14:12:51 +02:00
