Javi Martín
6fa67b5e53
Use active record translations for labels
...
This way we can simplify the way we generate form fields. In some cases,
we also use the human attribute in table headers, which IMHO makes
sense.
I haven't moved all of them: for example, sometimes a label is
different depending on whether it's shown to administrators, valuators,
or users. And I haven't touched the ones related to devise, since I
wasn't sure about possible side effects.
Note I've also removed placeholders when they had the same text as their
labels, since they weren't helpful. On the contrary, the added redundant
text to the form, potentially distracting users.
2019-10-07 01:56:23 +02:00
Javi Martín
3ea9f3cecf
Simplify generating form fields with labels
...
Instead of generating the label and then a field without a label, we can
directly generate a field with a label.
2019-10-05 16:01:58 +02:00
Senén Rodero Rodríguez
d1af36d1be
Remove uneeded lines
...
Rails form already add an error class when image or document attachments
has validations errors.
2019-09-23 10:51:25 +02:00
Javi Martín
911fe4e481
Simplify calls to render partial
...
We're also adding a bit of consistency, since most of our calls to
partial rendering omit the `partial` and `locals` keys.
2019-09-04 15:00:36 +02:00
Julian Herrero
b460c024f3
Use double quotes in app/helpers
2019-03-15 09:26:49 +01:00
Bertocq
7b40c84166
Rubocop fixes and rubocop todo update for those that can't be done right now
2017-10-17 22:23:53 +02:00
Senén Rodero Rodríguez
6c1d828a62
Remove unneded code
2017-09-27 11:38:38 +02:00
Senén Rodero Rodríguez
0a86727c6a
Move method 'recover_image_from_cache' from imageable controllers to image.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
d98d1312ca
Add _destroy parameter to nested image
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
f8d78ec4ab
Remove new_nested action from images controller. Use cocoon gem to manage new nested fields creation on images.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
95016a1bf3
Some renaming and cleaning
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
6d5571b177
Fix needed class for imageable js script.
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
966ff4dc03
User new direct uploads controllers action on imageable.
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
824dd26d5a
User new direct uploads controllers action on documentable. Skipped spec.
2017-09-26 13:55:51 +02:00
Senén Rodero Rodríguez
ceabd16d57
Refactor. Create index scope inside imageable shared examples to check index action of any imageable model. Add image to proposals index.
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
6f71da07ee
Duplicate documentable code and rename for imageable
2017-09-26 13:55:03 +02:00
