Add and apply Style/ArgumentsForwarding rule

We were using generic names like `args` and `options` which don't really
add anything to `*` or `**` because Ruby required us to.

That's no longer the case in Ruby 3.2, so we can simplify the code a
bit.
This commit is contained in:
Javi Martín
2024-02-29 00:22:58 +01:00
parent 7840c98660
commit fdfdbcbd0d
12 changed files with 25 additions and 27 deletions

View File

@@ -2,8 +2,8 @@ module FeatureFlags
extend ActiveSupport::Concern
class_methods do
def feature_flag(name, *options)
before_action(*options) do
def feature_flag(name, *)
before_action(*) do
check_feature_flag(name)
end
end

View File

@@ -7,8 +7,8 @@ module HasFilters
end
class_methods do
def has_filters(valid_filters, *args)
before_action(*args) do
def has_filters(valid_filters, *)
before_action(*) do
@valid_filters = valid_filters.respond_to?(:call) ? valid_filters.call(self) : valid_filters
@current_filter = @valid_filters.include?(params[:filter]) ? params[:filter] : @valid_filters.first
end

View File

@@ -7,8 +7,8 @@ module HasOrders
end
class_methods do
def has_orders(valid_orders, *args)
before_action(*args) do |c|
def has_orders(valid_orders, *)
before_action(*) do |c|
@valid_orders = valid_orders.respond_to?(:call) ? valid_orders.call(c) : valid_orders.dup
@valid_orders.delete("relevance") if params[:search].blank?
@current_order = @valid_orders.include?(params[:order]) ? params[:order] : @valid_orders.first

View File

@@ -1,10 +1,10 @@
module RemotelyTranslatable
private
def detect_remote_translations(*args)
def detect_remote_translations(*)
return [] unless Setting["feature.remote_translations"].present? && api_key_has_been_set_in_secrets?
RemoteTranslation.for(*args)
RemoteTranslation.for(*)
end
def api_key_has_been_set_in_secrets?