Check exact array contents instead of inclusion

We're using `eq` and `match_array` in most places, but there were a few
places where we were still checking each element is included in the
array. This is a bit dangerous, because the array could have duplicate
elements, and we wouldn't detect them with `include`.
This commit is contained in:
Javi Martín
2019-09-26 19:54:26 +02:00
parent 9f0088396e
commit fd1325768f
21 changed files with 71 additions and 97 deletions

View File

@@ -46,7 +46,7 @@ describe Vote do
debate = create(:debate)
vote = create(:vote, votable: debate)
expect(Vote.public_for_api).to include(vote)
expect(Vote.public_for_api).to eq [vote]
end
it "blocks votes on hidden debates" do
@@ -60,7 +60,7 @@ describe Vote do
proposal = create(:proposal)
vote = create(:vote, votable: proposal)
expect(Vote.public_for_api).to include(vote)
expect(Vote.public_for_api).to eq [vote]
end
it "blocks votes on hidden proposals" do
@@ -74,7 +74,7 @@ describe Vote do
comment = create(:comment)
vote = create(:vote, votable: comment)
expect(Vote.public_for_api).to include(vote)
expect(Vote.public_for_api).to eq [vote]
end
it "blocks votes on hidden comments" do