Check exact array contents instead of inclusion

We're using `eq` and `match_array` in most places, but there were a few
places where we were still checking each element is included in the
array. This is a bit dangerous, because the array could have duplicate
elements, and we wouldn't detect them with `include`.
This commit is contained in:
Javi Martín
2019-09-26 19:54:26 +02:00
parent 9f0088396e
commit fd1325768f
21 changed files with 71 additions and 97 deletions

View File

@@ -25,8 +25,7 @@ describe Notification do
read_notification2 = create(:notification, :read)
unread_notification = create(:notification)
expect(Notification.read).to include read_notification1
expect(Notification.read).to include read_notification2
expect(Notification.read).to match_array [read_notification1, read_notification2]
expect(Notification.read).not_to include unread_notification
end
end
@@ -37,8 +36,7 @@ describe Notification do
unread_notification1 = create(:notification)
unread_notification2 = create(:notification)
expect(Notification.unread).to include unread_notification1
expect(Notification.unread).to include unread_notification2
expect(Notification.unread).to match_array [unread_notification1, unread_notification2]
expect(Notification.unread).not_to include read_notification
end
end