consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check exact array contents instead of inclusion

Browse Source 
We're using `eq` and `match_array` in most places, but there were a few
places where we were still checking each element is included in the
array. This is a bit dangerous, because the array could have duplicate
elements, and we wouldn't detect them with `include`.
This commit is contained in:
Javi Martín
2019-09-26 19:54:26 +02:00
parent 9f0088396e
commit fd1325768f
21 changed files with 71 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/models/comment_spec.rb
View File

@@ -139,7 +139,7 @@ describe Comment do
it "returns comments" do
comment = create(:comment)
expect(Comment.public_for_api).to include(comment)
expect(Comment.public_for_api).to eq [comment]
end
it "does not return hidden comments" do
@@ -149,10 +149,9 @@ describe Comment do
end
it "returns comments on debates" do
debate = create(:debate)
comment = create(:comment, commentable: debate)
comment = create(:comment, commentable: create(:debate))
expect(Comment.public_for_api).to include(comment)
expect(Comment.public_for_api).to eq [comment]
end
it "does not return comments on hidden debates" do
@@ -166,7 +165,7 @@ describe Comment do
proposal = create(:proposal)
comment = create(:comment, commentable: proposal)
expect(Comment.public_for_api).to include(comment)
expect(Comment.public_for_api).to eq [comment]
end
it "does not return comments on hidden proposals" do