Check exact array contents instead of inclusion

We're using `eq` and `match_array` in most places, but there were a few
places where we were still checking each element is included in the
array. This is a bit dangerous, because the array could have duplicate
elements, and we wouldn't detect them with `include`.

spec/lib/acts_as_taggable_on_spec.rb

@@ -73,7 +73,7 @@ describe ActsAsTaggableOn do
         proposal.tag_list.add(tag)
         proposal.save
 
-        expect(ActsAsTaggableOn::Tag.public_for_api).to include(tag)
+        expect(ActsAsTaggableOn::Tag.public_for_api).to eq [tag]
       end
 
       it "returns tags whose kind is 'category' and have at least one tagging whose taggable is not hidden" do
@@ -82,7 +82,7 @@ describe ActsAsTaggableOn do
         proposal.tag_list.add(tag)
         proposal.save
 
-        expect(ActsAsTaggableOn::Tag.public_for_api).to include(tag)
+        expect(ActsAsTaggableOn::Tag.public_for_api).to eq [tag]
       end
 
       it "blocks other kinds of tags" do
@@ -126,7 +126,7 @@ describe ActsAsTaggableOn do
         proposal.tag_list.add(tag)
         proposal.save
 
-        expect(ActsAsTaggableOn::Tag.public_for_api).to include(tag)
+        expect(ActsAsTaggableOn::Tag.public_for_api).to eq [tag]
 
         proposal.delete
 

spec/lib/email_digests_spec.rb

@@ -14,7 +14,7 @@ describe EmailDigest do
 
       email_digest = EmailDigest.new(user1)
 
-      expect(email_digest.notifications).to include(notification1)
+      expect(email_digest.notifications).to eq [notification1]
       expect(email_digest.notifications).not_to include(notification2)
     end
 
@@ -29,7 +29,7 @@ describe EmailDigest do
 
       email_digest = EmailDigest.new(user)
 
-      expect(email_digest.notifications).to include(notification1)
+      expect(email_digest.notifications).to eq [notification1]
       expect(email_digest.notifications).not_to include(notification2)
     end
 

spec/lib/user_segments_spec.rb

@@ -10,7 +10,7 @@ describe UserSegments do
       active_user = create(:user)
       erased_user = create(:user, erased_at: Time.current)
 
-      expect(UserSegments.all_users).to include active_user
+      expect(UserSegments.all_users).to eq [active_user]
       expect(UserSegments.all_users).not_to include erased_user
     end
   end
@@ -21,7 +21,7 @@ describe UserSegments do
       active_admin = create(:administrator).user
       erased_user = create(:user, erased_at: Time.current)
 
-      expect(UserSegments.administrators).to include active_admin
+      expect(UserSegments.administrators).to eq [active_admin]
       expect(UserSegments.administrators).not_to include active_user
       expect(UserSegments.administrators).not_to include erased_user
     end
@@ -34,9 +34,8 @@ describe UserSegments do
       create(:proposal, :retired, author: user3)
 
       all_proposal_authors = UserSegments.all_proposal_authors
-      expect(all_proposal_authors).to include user1
-      expect(all_proposal_authors).to include user2
-      expect(all_proposal_authors).to include user3
+
+      expect(all_proposal_authors).to match_array [user1, user2, user3]
     end
 
     it "does not return duplicated users" do
@@ -55,8 +54,8 @@ describe UserSegments do
       create(:proposal, author: user1)
 
       proposal_authors = UserSegments.proposal_authors
-      expect(proposal_authors).to include user1
-      expect(proposal_authors).not_to include user2
+
+      expect(proposal_authors).to eq [user1]
     end
 
     it "does not return duplicated users" do
@@ -75,8 +74,8 @@ describe UserSegments do
       investment.update(budget: budget)
 
       investment_authors = UserSegments.investment_authors
-      expect(investment_authors).to include user1
-      expect(investment_authors).not_to include user2
+
+      expect(investment_authors).to eq [user1]
     end
 
     it "does not return duplicated users" do
@@ -113,11 +112,7 @@ describe UserSegments do
       unfeasible_investment_finished.update(budget: budget)
 
       investment_authors = UserSegments.feasible_and_undecided_investment_authors
-      expect(investment_authors).to include user1
-      expect(investment_authors).to include user2
-      expect(investment_authors).to include user3
-      expect(investment_authors).to include user4
-      expect(investment_authors).to include user5
+      expect(investment_authors).to match_array [user1, user2, user3, user4, user5]
       expect(investment_authors).not_to include user6
     end
 
@@ -142,8 +137,8 @@ describe UserSegments do
       unselected_investment.update(budget: budget)
 
       investment_authors = UserSegments.selected_investment_authors
-      expect(investment_authors).to include user1
-      expect(investment_authors).not_to include user2
+
+      expect(investment_authors).to eq [user1]
     end
 
     it "does not return duplicated users" do
@@ -167,8 +162,8 @@ describe UserSegments do
       selected_investment.update(budget: budget)
 
       investment_authors = UserSegments.winner_investment_authors
-      expect(investment_authors).to include user1
-      expect(investment_authors).not_to include user2
+
+      expect(investment_authors).to eq [user1]
     end
 
     it "does not return duplicated users" do
@@ -191,7 +186,8 @@ describe UserSegments do
       investment1.update(budget: budget)
 
       current_budget_investments = UserSegments.current_budget_investments
-      expect(current_budget_investments).to include investment1
+
+      expect(current_budget_investments).to eq [investment1]
       expect(current_budget_investments).not_to include investment2
     end
   end