Fix legislation proposal crash with SDG enabled
Now we check the given record or name is a relatable instance or class to avoid trying to render goals for records which don't have a goals association. Note for now we are ignoring the case where we pass a controller_path for an unsupported class (for example, `legislation/proposals` or `budgets/headings`) because we never use it. We might need to revisit this case in the future. Co-Authored-By: Javi Martín <javim@elretirao.net>
This commit is contained in:
committed by
Javi Martín
parent
046e2273c7
commit
fb611d91ca
@@ -31,6 +31,12 @@ describe SDG::ProcessEnabled do
|
||||
|
||||
expect(process).to be_enabled
|
||||
end
|
||||
|
||||
it "returns false when record or name are not a relatable type" do
|
||||
expect(SDG::ProcessEnabled.new(build(:legislation_proposal))).not_to be_enabled
|
||||
expect(SDG::ProcessEnabled.new("Legislation::Proposal")).not_to be_enabled
|
||||
expect(SDG::ProcessEnabled.new("officing/booth")).not_to be_enabled
|
||||
end
|
||||
end
|
||||
|
||||
context "SDG feature is disabled" do
|
||||
|
||||
Reference in New Issue
Block a user