consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary content_tag calls

Browse Source 
We're usually using HTML tags in views instead.
This commit is contained in:
Javi Martín
2019-06-21 01:01:13 +02:00
parent 3ba8b05cbb
commit fa070f326e
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/views/admin/legislation/questions/index.html.erb
View File

@@ -33,13 +33,11 @@
<%= link_to question.title, edit_admin_legislation_process_question_path(@process, question) %> <%= link_to question.title, edit_admin_legislation_process_question_path(@process, question) %>
</td> </td>
<td> <td>
<%= content_tag :ul do %> <ul>
<% question.question_options.each do |question_option| %> <% question.question_options.each do |question_option| %>
<%= content_tag :li do %> <li><%= "#{question_option.value} (#{question_option.answers_count})" %></li>
<%= question_option.value %> (<%= question_option.answers_count %>)
<% end %>
<% end %>
<% end %> <% end %>
</ul>
</td> </td>
<td class="text-center"><%= question.answers_count %></td> <td class="text-center"><%= question.answers_count %></td>
<td class="text-center"><%= link_to question.comments.count, legislation_process_question_path(@process, question, anchor: "comments") %></td> <td class="text-center"><%= link_to question.comments.count, legislation_process_question_path(@process, question, anchor: "comments") %></td>

8
app/views/legislation/questions/show.html.erb
View File

@@ -11,17 +11,17 @@
<div class="small-12 medium-3 column"> <div class="small-12 medium-3 column">
<% if @question.next_question_id %> <% if @question.next_question_id %>
<%= link_to legislation_process_question_path(@process, @question.next_question_id), class: "quiz-next-link" do %> <%= link_to legislation_process_question_path(@process, @question.next_question_id), class: "quiz-next-link" do %>
<%= content_tag :div, class: "quiz-next" do %> <div class="quiz-next">
<%= t(".next_question") %> <%= t(".next_question") %>
<span class="icon-angle-right" aria-hidden="true"> <span class="icon-angle-right" aria-hidden="true">
<% end %> </div>
<% end %> <% end %>
<% elsif @question.first_question_id %> <% elsif @question.first_question_id %>
<%= link_to legislation_process_question_path(@process, @question.first_question_id), class: "quiz-next-link" do %> <%= link_to legislation_process_question_path(@process, @question.first_question_id), class: "quiz-next-link" do %>
<%= content_tag :div, class: "quiz-next" do %> <div class="quiz-next">
<%= t(".first_question") %> <%= t(".first_question") %>
<span class="icon-angle-right" aria-hidden="true"> <span class="icon-angle-right" aria-hidden="true">
<% end %> </div>
<% end %> <% end %>
<% end %> <% end %>
</div> </div>