diff --git a/.rubocop.yml b/.rubocop.yml index b614da684..115d3be5a 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -62,4 +62,7 @@ RSpec/DescribeSymbol: Enabled: true RSpec/DescribedClass: + Enabled: true + +RSpec/EmptyExampleGroup: Enabled: true \ No newline at end of file diff --git a/spec/features/legislation/draft_versions_spec.rb b/spec/features/legislation/draft_versions_spec.rb index ea2cb854d..e34cd595c 100644 --- a/spec/features/legislation/draft_versions_spec.rb +++ b/spec/features/legislation/draft_versions_spec.rb @@ -140,6 +140,7 @@ feature 'Legislation Draft Versions' do context 'Annotations', :js do let(:user) { create(:user) } + background { login_as user } scenario 'Visit as anonymous' do @@ -218,6 +219,7 @@ feature 'Legislation Draft Versions' do context "Merged annotations", :js do let(:user) { create(:user) } + background { login_as user } scenario 'View annotations and comments in an included range' do diff --git a/spec/features/legislation/processes_spec.rb b/spec/features/legislation/processes_spec.rb index e80e81dba..4206657a9 100644 --- a/spec/features/legislation/processes_spec.rb +++ b/spec/features/legislation/processes_spec.rb @@ -3,6 +3,7 @@ require 'rails_helper' feature 'Legislation' do let!(:administrator) { create(:administrator).user } + shared_examples "not published permissions" do |path| let(:not_published_process) { create(:legislation_process, :not_published, title: "Process not published") } diff --git a/spec/models/abilities/common_spec.rb b/spec/models/abilities/common_spec.rb index c8789d48b..4b4ac5047 100644 --- a/spec/models/abilities/common_spec.rb +++ b/spec/models/abilities/common_spec.rb @@ -157,6 +157,7 @@ describe Abilities::Common do let(:own_spending_proposal) { create(:spending_proposal, author: user) } let(:own_direct_message) { create(:direct_message, sender: user) } + before{ user.update(residence_verified_at: Time.current, confirmed_phone: "1") } describe "Proposal" do @@ -239,6 +240,7 @@ describe Abilities::Common do describe "when level 3 verified" do let(:own_spending_proposal) { create(:spending_proposal, author: user) } let(:own_direct_message) { create(:direct_message, sender: user) } + before{ user.update(verified_at: Time.current) } it { should be_able_to(:vote, Proposal) } diff --git a/spec/models/abilities/valuator_spec.rb b/spec/models/abilities/valuator_spec.rb index 0d56158e2..214e68f6e 100644 --- a/spec/models/abilities/valuator_spec.rb +++ b/spec/models/abilities/valuator_spec.rb @@ -11,6 +11,7 @@ describe Abilities::Valuator do before(:each) { assigned_investment.valuators << valuator } let(:finished_assigned_investment) { create(:budget_investment, budget: create(:budget, phase: 'finished')) } + before(:each) { finished_assigned_investment.valuators << valuator } it { should be_able_to(:read, SpendingProposal) } diff --git a/spec/models/budget_spec.rb b/spec/models/budget_spec.rb index d3a7574e3..7b80d7a67 100644 --- a/spec/models/budget_spec.rb +++ b/spec/models/budget_spec.rb @@ -125,6 +125,7 @@ describe Budget do describe "investments_orders" do let(:budget) { create(:budget) } + it "is random when accepting and reviewing" do budget.phase = 'accepting' expect(budget.investments_orders).to eq(['random']) diff --git a/spec/models/debate_spec.rb b/spec/models/debate_spec.rb index 7b5f7a462..6b2a043e3 100644 --- a/spec/models/debate_spec.rb +++ b/spec/models/debate_spec.rb @@ -88,6 +88,7 @@ describe Debate do describe "#editable?" do let(:debate) { create(:debate) } + before(:each) { Setting["max_votes_for_debate_edit"] = 3 } after(:each) { Setting["max_votes_for_debate_edit"] = 1000 } @@ -111,6 +112,7 @@ describe Debate do describe "#editable_by?" do let(:debate) { create(:debate) } + before(:each) { Setting["max_votes_for_debate_edit"] = 1 } after(:each) { Setting["max_votes_for_debate_edit"] = 1000 } diff --git a/spec/models/proposal_spec.rb b/spec/models/proposal_spec.rb index 57d347854..454e46389 100644 --- a/spec/models/proposal_spec.rb +++ b/spec/models/proposal_spec.rb @@ -162,6 +162,7 @@ describe Proposal do describe "#editable?" do let(:proposal) { create(:proposal) } + before(:each) {Setting["max_votes_for_proposal_edit"] = 5} after(:each) {Setting["max_votes_for_proposal_edit"] = 1000}