From f90c23ca8820255b0230aa09a0857fd08b5f1c04 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Wed, 11 Aug 2021 16:17:04 +0200
Subject: [PATCH] Add and apply Lint/DuplicateBranch rubocop rule

This rule was introduced in rubocop 1.3.0.
---
 .rubocop.yml         | 3 +++
 app/models/budget.rb | 4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index a44b298cb..35bbd2120 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -160,6 +160,9 @@ Lint/BooleanSymbol:
 Lint/ConstantDefinitionInBlock:
   Enabled: true
 
+Lint/DuplicateBranch:
+  Enabled: true
+
 Lint/DuplicateMethods:
   Enabled: true
 
diff --git a/app/models/budget.rb b/app/models/budget.rb
index eaf35aae4..94928c0d4 100644
--- a/app/models/budget.rb
+++ b/app/models/budget.rb
@@ -187,12 +187,10 @@ class Budget < ApplicationRecord
 
   def investments_orders
     case phase
-    when "accepting", "reviewing"
+    when "accepting", "reviewing", "finished"
       %w[random]
     when "publishing_prices", "balloting", "reviewing_ballots"
       %w[random price]
-    when "finished"
-      %w[random]
     else
       %w[random confidence_score]
     end