consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable RSpec/ExpectActual cop and fix all issues

Browse Source 
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
This commit is contained in:
Bertocq
2018-01-07 01:38:33 +01:00
parent 0698043340
commit f6aed3f9f1
9 changed files with 128 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spec/features/moderation/proposals_spec.rb
View File

@@ -179,27 +179,27 @@ feature 'Moderate proposals' do
end
scenario "sorting proposals" do
create(:proposal, title: "Flagged proposal", created_at: Time.current - 1.day, flags_count: 5)
create(:proposal, title: "Flagged newer proposal", created_at: Time.current - 12.hours, flags_count: 3)
create(:proposal, title: "Newer proposal", created_at: Time.current)
flagged_proposal = create(:proposal, title: "Flagged proposal", created_at: Time.current - 1.day, flags_count: 5)
flagged_new_proposal = create(:proposal, title: "Flagged new proposal", created_at: Time.current - 12.hours, flags_count: 3)
newer_proposal = create(:proposal, title: "Newer proposal", created_at: Time.current)
visit moderation_proposals_path(order: 'created_at')
expect("Flagged newer proposal").to appear_before("Flagged proposal")
expect(flagged_new_proposal.title).to appear_before(flagged_proposal.title)
visit moderation_proposals_path(order: 'flags')
expect("Flagged proposal").to appear_before("Flagged newer proposal")
expect(flagged_proposal.title).to appear_before(flagged_new_proposal.title)
visit moderation_proposals_path(filter: 'all', order: 'created_at')
expect("Newer proposal").to appear_before("Flagged newer proposal")
expect("Flagged newer proposal").to appear_before("Flagged proposal")
expect(newer_proposal.title).to appear_before(flagged_new_proposal.title)
expect(flagged_new_proposal.title).to appear_before(flagged_proposal.title)
visit moderation_proposals_path(filter: 'all', order: 'flags')
expect("Flagged proposal").to appear_before("Flagged newer proposal")
expect("Flagged newer proposal").to appear_before("Newer proposal")
expect(flagged_proposal.title).to appear_before(flagged_new_proposal.title)
expect(flagged_new_proposal.title).to appear_before(newer_proposal.title)
end
end
end