consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable RSpec/ExpectActual cop and fix all issues

Browse Source 
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
This commit is contained in:
Bertocq
2018-01-07 01:38:33 +01:00
parent 0698043340
commit f6aed3f9f1
9 changed files with 128 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
spec/features/management/proposals_spec.rb
View File

@@ -194,9 +194,12 @@ feature 'Proposals' do
end
scenario "Filtering proposals to be printed", :js do
create(:proposal, title: 'Worst proposal').update_column(:confidence_score, 2)
create(:proposal, title: 'Best proposal').update_column(:confidence_score, 10)
create(:proposal, title: 'Medium proposal').update_column(:confidence_score, 5)
worst_proposal = create(:proposal, title: 'Worst proposal')
worst_proposal.update_column(:confidence_score, 2)
best_proposal = create(:proposal, title: 'Best proposal')
best_proposal.update_column(:confidence_score, 10)
medium_proposal = create(:proposal, title: 'Medium proposal')
medium_proposal.update_column(:confidence_score, 5)
user = create(:user, :level_two)
login_managed_user(user)
@@ -206,8 +209,8 @@ feature 'Proposals' do
expect(page).to have_selector('.js-order-selector[data-order="confidence_score"]')
within(".proposals-list") do
expect('Best proposal').to appear_before('Medium proposal')
expect('Medium proposal').to appear_before('Worst proposal')
expect(best_proposal.title).to appear_before(medium_proposal.title)
expect(medium_proposal.title).to appear_before(worst_proposal.title)
end
select 'newest', from: 'order-selector'
@@ -218,8 +221,8 @@ feature 'Proposals' do
expect(current_url).to include('page=1')
within(".proposals-list") do
expect('Medium proposal').to appear_before('Best proposal')
expect('Best proposal').to appear_before('Worst proposal')
expect(medium_proposal.title).to appear_before(best_proposal.title)
expect(best_proposal.title).to appear_before(worst_proposal.title)
end
end