From f60d307a59085534a0069920536f9c51408136da Mon Sep 17 00:00:00 2001 From: taitus Date: Wed, 22 Apr 2020 17:48:08 +0200 Subject: [PATCH] Mitigate recurrent flaky specs for voting comments --- spec/system/comments/budget_investments_spec.rb | 5 +++++ spec/system/comments/polls_spec.rb | 5 +++++ spec/system/comments/proposals_spec.rb | 5 +++++ spec/system/comments/topics_spec.rb | 10 ++++++++++ 4 files changed, 25 insertions(+) diff --git a/spec/system/comments/budget_investments_spec.rb b/spec/system/comments/budget_investments_spec.rb index e1b700ae0..2970da0df 100644 --- a/spec/system/comments/budget_investments_spec.rb +++ b/spec/system/comments/budget_investments_spec.rb @@ -573,6 +573,11 @@ describe "Commenting Budget::Investments" do within("#comment_#{comment.id}_votes") do find(".in_favor a").click + + within(".in_favor") do + expect(page).to have_content "1" + end + find(".in_favor a").click within(".in_favor") do diff --git a/spec/system/comments/polls_spec.rb b/spec/system/comments/polls_spec.rb index b224e32a4..ad4db74ec 100644 --- a/spec/system/comments/polls_spec.rb +++ b/spec/system/comments/polls_spec.rb @@ -525,6 +525,11 @@ describe "Commenting polls" do within("#comment_#{comment.id}_votes") do find(".in_favor a").click + + within(".in_favor") do + expect(page).to have_content "1" + end + find(".in_favor a").click within(".in_favor") do diff --git a/spec/system/comments/proposals_spec.rb b/spec/system/comments/proposals_spec.rb index e1f5c7daf..e1b74613b 100644 --- a/spec/system/comments/proposals_spec.rb +++ b/spec/system/comments/proposals_spec.rb @@ -505,6 +505,11 @@ describe "Commenting proposals" do within("#comment_#{comment.id}_votes") do find(".in_favor a").click + + within(".in_favor") do + expect(page).to have_content "1" + end + find(".in_favor a").click within(".in_favor") do diff --git a/spec/system/comments/topics_spec.rb b/spec/system/comments/topics_spec.rb index 0ebc30cf7..4afc13ff1 100644 --- a/spec/system/comments/topics_spec.rb +++ b/spec/system/comments/topics_spec.rb @@ -555,6 +555,11 @@ describe "Commenting topics from proposals" do within("#comment_#{comment.id}_votes") do find(".in_favor a").click + + within(".in_favor") do + expect(page).to have_content "1" + end + find(".in_favor a").click within(".in_favor") do @@ -1104,6 +1109,11 @@ describe "Commenting topics from budget investments" do within("#comment_#{comment.id}_votes") do find(".in_favor a").click + + within(".in_favor") do + expect(page).to have_content "1" + end + find(".in_favor a").click within(".in_favor") do