From f5c8d5eea6f76d7ce351f92661b3204f861f5b9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 14 May 2020 00:12:14 +0200 Subject: [PATCH] Submit the form after the image is attached We were submitting the form without checking the AJAX request to attach the image had finished, so sometimes two requests were executed at the same time. Sometimes this made InvisibleCaptcha to go crazy and report the form was submitted too quickly. Checking the first AJAX request has finished before submitting the form solves the problem. --- spec/shared/system/nested_imageable.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/spec/shared/system/nested_imageable.rb b/spec/shared/system/nested_imageable.rb index 19592858f..6977e3e81 100644 --- a/spec/shared/system/nested_imageable.rb +++ b/spec/shared/system/nested_imageable.rb @@ -182,6 +182,8 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p Rails.root.join("spec/fixtures/files/clippy.jpg") ) + expect(page).to have_selector ".loading-bar.complete" + click_on submit_button expect(page).to have_content imageable_success_notice @@ -197,6 +199,8 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p Rails.root.join("spec/fixtures/files/clippy.jpg") ) + expect(page).to have_selector ".loading-bar.complete" + click_on submit_button imageable_redirected_to_resource_show_or_navigate_to