consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove all grid-row Sass rules

Browse Source 
We were using these rules in order to set the maximum width of an
element to `$global-width`. However, since we now do so in the <body>
element, there's no need to apply these rules to "rows".

Note we're adding `overflow: hidden` to the budget subheader. That's
because it only contains `float` element inside, and we're now missing
the `.row::before` and `.row::after` rules which make sure float
elements are rendered properly.
This commit is contained in:
Javi Martín
2021-07-05 23:36:03 +02:00
parent 9cc4d52723
commit f00cb631bc
7 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/stylesheets/budgets/investments-list.scss
View File

@@ -1,5 +1,6 @@
.investments-list { .investments-list {
@include flex-grid-row; display: flex;
flex-wrap: wrap;
margin-top: $line-height; margin-top: $line-height;
> header { > header {

1
app/assets/stylesheets/budgets/investments/new.scss
View File

@@ -2,7 +2,6 @@
$border-width: 4px; $border-width: 4px;
> * { > * {
@include grid-row;
@include grid-column-gutter; @include grid-column-gutter;
} }

2
app/assets/stylesheets/budgets/subheader.scss
View File

@@ -1,7 +1,7 @@
.budget-subheader { .budget-subheader {
@include grid-row;
margin-bottom: $line-height; margin-bottom: $line-height;
margin-top: $line-height; margin-top: $line-height;
overflow: hidden;
.current-phase { .current-phase {
text-transform: uppercase; text-transform: uppercase;

1
app/assets/stylesheets/layout.scss
View File

@@ -2068,7 +2068,6 @@ table {
} }
a > * { a > * {
@include grid-row;
padding: 0 rem-calc(16); padding: 0 rem-calc(16);
&:empty { &:empty {

1
app/assets/stylesheets/legislation_process.scss
View File

@@ -966,7 +966,6 @@
.process-summary { .process-summary {
> section { > section {
@include grid-row;
margin-top: $line-height * 1.5; margin-top: $line-height * 1.5;
padding: 0 rem-calc(16); padding: 0 rem-calc(16);
} }

6
app/assets/stylesheets/sdg/goals/index.scss
View File

@@ -3,13 +3,13 @@
.section-header { .section-header {
h1 { h1 {
@include grid-row;
@include grid-column-gutter; @include grid-column-gutter;
&::before { &::before {
@extend %font-icon; @extend %font-icon;
background: image-url("sdg.svg"); background: image-url("sdg.svg");
content: "";
display: inline-block; display: inline-block;
height: 1.5em; height: 1.5em;
width: 1.5em; width: 1.5em;
@@ -21,9 +21,10 @@
$spacing: 1.5%; $spacing: 1.5%;
@include sdg-goal-list($spacing); @include sdg-goal-list($spacing);
@include grid-row;
@include grid-column-gutter; @include grid-column-gutter;
margin-left: auto;
margin-right: auto;
max-width: 60rem; max-width: 60rem;
width: 100%; width: 100%;
@@ -40,7 +41,6 @@
} }
.sdg-phase { .sdg-phase {
@include grid-row;
@include grid-column-gutter; @include grid-column-gutter;
.cards-container { .cards-container {

1
app/assets/stylesheets/sdg/goals/show.scss
View File

@@ -1,5 +1,4 @@
.sdg-goal-show { .sdg-goal-show {
@include grid-row;
> :not(.feeds-participation) { > :not(.feeds-participation) {
@include grid-column-gutter; @include grid-column-gutter;