From f27d1231bbd998ba0dd6e0d5b89dd9df395a2eb4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 28 Apr 2021 20:35:44 +0200 Subject: [PATCH 01/14] Remove unused CSS selector In the dashboard navigation, each link is inside a list item, so the selector `a ~ a` is never used. --- app/assets/stylesheets/dashboard.scss | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/assets/stylesheets/dashboard.scss b/app/assets/stylesheets/dashboard.scss index 1424032c2..86a02be16 100644 --- a/app/assets/stylesheets/dashboard.scss +++ b/app/assets/stylesheets/dashboard.scss @@ -352,10 +352,6 @@ a { @include brand-text; - - ~ a { - color: $text; - } } [class^="icon-"] { From 716ab81ee4a53719ec9e55576665a4efd27b68c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 29 Apr 2021 15:35:17 +0200 Subject: [PATCH 02/14] Remove obsolete styles These styles aren't necessary since commit aabf8493f. Now the "Go back" link in the budgets section can use the same color as in the other sections, while the other texts inherit the usual colors. --- app/assets/stylesheets/participation.scss | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss index 5c48631ec..9869f18b4 100644 --- a/app/assets/stylesheets/participation.scss +++ b/app/assets/stylesheets/participation.scss @@ -1235,16 +1235,6 @@ margin-bottom: 0; } - h1, - h2, - h3, - .back, - .icon-angle-left, - p, - a { - color: $text; - } - .tagline { display: block; font-size: $small-font-size; From 143ba490cb1ce3372a8459e6d037ee2c8742c2ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 29 Apr 2021 15:49:03 +0200 Subject: [PATCH 03/14] Remove redundant CSS color properties Since we were using the color already defined in the `` element, these elements can inherit that color instead of specifying it. --- app/assets/stylesheets/layout.scss | 1 - app/assets/stylesheets/participation.scss | 7 ------- 2 files changed, 8 deletions(-) diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 22b2ed2fe..4d4089be6 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -873,7 +873,6 @@ body > header, // ---------- footer { - color: $text; .logo a { font-family: "Lato" !important; diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss index 9869f18b4..e8199d970 100644 --- a/app/assets/stylesheets/participation.scss +++ b/app/assets/stylesheets/participation.scss @@ -149,7 +149,6 @@ } .percentage { - color: $text; font-size: $tiny-font-size; position: absolute; right: 6px; @@ -180,7 +179,6 @@ } .total-supports { - color: $text; display: block; font-weight: bold; text-align: center; @@ -720,7 +718,6 @@ .proposal-description, .investment-project-description, .budget-investment-description { - color: $text; font-size: rem-calc(13); height: rem-calc(72); line-height: $line-height; @@ -742,10 +739,6 @@ position: absolute; width: 100%; } - - p { - color: $text; - } } .divider { From c6b962e64f59557b6d5e85b3f1d292749379aaa5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 29 Apr 2021 16:30:26 +0200 Subject: [PATCH 04/14] Remove unused style We don't have any links inside poll question headings. --- app/assets/stylesheets/participation.scss | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss index e8199d970..0a301284d 100644 --- a/app/assets/stylesheets/participation.scss +++ b/app/assets/stylesheets/participation.scss @@ -1834,10 +1834,6 @@ h3 { padding-top: $line-height; - - a { - color: $text; - } } } From cd22d65a3f763f9fa58f3ea24ddae873e3d84494 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 29 Apr 2021 17:44:27 +0200 Subject: [PATCH 05/14] Remove no longer necessary style The color of the top links is inherited from the color of the `
` element, which was added in commit e2d540d20. --- app/assets/stylesheets/layout.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 4d4089be6..56ce2f20e 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -704,7 +704,6 @@ body > header, .top-links { background: $dark; - color: #fff; font-size: $small-font-size; padding-right: $line-height / 2; From f32c0e3c9127e9645ded740922b858c45afeb2af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 29 Apr 2021 19:37:52 +0200 Subject: [PATCH 06/14] Remove obsolete style for f-dropdown It isn't used since commit 3752f3a53. --- app/assets/stylesheets/layout.scss | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 56ce2f20e..93bd17600 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -139,25 +139,6 @@ a { } } -.f-dropdown { - li a { - font-size: $small-font-size; - - &:hover { - color: $link-hover; - } - } - - li:hover, - .f-dropdown li:focus { - background: #fff; - } - - &.open { - outline: none; - } -} - .margin { margin-bottom: $line-height; margin-top: $line-height; From 41235f9f0224b97a1e47c9ec0d0941b7ddccc8f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 15 May 2021 17:49:34 +0200 Subject: [PATCH 07/14] Remove obsolete menu-text styles Since commit dcec003d0 we're only using the menu-text class in the admin layouts. So instead of defining styles for menu-text and then overwriting them in the admin section, we can define them just in the admin section. Since we don't have tags in the menu-text element in the admin section, we can remove their styles. And we can also remove the styles we were overriding twice (like `line-height`). --- app/assets/stylesheets/admin.scss | 13 +++++++------ app/assets/stylesheets/layout.scss | 27 --------------------------- 2 files changed, 7 insertions(+), 33 deletions(-) diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss index 6115a94aa..bb38174e3 100644 --- a/app/assets/stylesheets/admin.scss +++ b/app/assets/stylesheets/admin.scss @@ -116,6 +116,7 @@ $table-header: #ecf1f6; } .menu .menu-text { + padding: 0; h1 { margin-top: $line-height / 2; @@ -133,12 +134,12 @@ $table-header: #ecf1f6; } a { - color: #000 !important; - line-height: $line-height !important; - - @include breakpoint(medium) { - line-height: $line-height !important; - } + color: #000; + display: inline-block; + font-family: "Lato" !important; + font-size: rem-calc(24); + font-weight: lighter; + padding: 0; } } diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 93bd17600..9b5b95a29 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -550,33 +550,6 @@ body > header, padding-right: rem-calc(15); } - .menu .menu-text { - padding: 0; - - a { - color: #fff; - display: inline-block; - font-family: "Lato" !important; - font-size: rem-calc(24); - font-weight: lighter; - line-height: $line-height * 2; - padding: 0; - - @include breakpoint(medium) { - line-height: rem-calc(80); - margin-top: 0; - } - - img { - - @include breakpoint(medium) { - margin-right: $line-height / 2; - margin-top: 0; - } - } - } - } - .menu > li { display: block; width: 100%; From d45bf4d5da3a1cdda356ece80080d830dc1e5b06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 29 Apr 2021 20:20:38 +0200 Subject: [PATCH 08/14] Remove redundant menu link colors The color is inherited from the `.top-bar .menu > li a` selector. --- app/assets/stylesheets/admin.scss | 1 - app/assets/stylesheets/layout.scss | 1 - 2 files changed, 2 deletions(-) diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss index bb38174e3..ba749904e 100644 --- a/app/assets/stylesheets/admin.scss +++ b/app/assets/stylesheets/admin.scss @@ -134,7 +134,6 @@ $table-header: #ecf1f6; } a { - color: #000; display: inline-block; font-family: "Lato" !important; font-size: rem-calc(24); diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 9b5b95a29..3a8163578 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -583,7 +583,6 @@ body > header, .has-submenu { &.is-active a { - color: #fff; font-weight: bold; } } From c67fc8a8145ac51130d6bfa31638940c97deadcc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 15 May 2021 20:36:56 +0200 Subject: [PATCH 09/14] Remove unused CSS for verified organizations It isn't used since commit f17d0a663. --- app/assets/stylesheets/admin.scss | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss index ba749904e..27328ff92 100644 --- a/app/assets/stylesheets/admin.scss +++ b/app/assets/stylesheets/admin.scss @@ -478,16 +478,6 @@ code { font-size: $base-font-size; } -.verified { - color: $check; - - a { - border-bottom: 1px dotted $check; - color: $check; - font-size: rem-calc(12); - } -} - .archived { color: $text-medium; font-size: rem-calc(12); From 4d69882e77e9daea7187c582649357557fbe28a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 15 May 2021 21:05:43 +0200 Subject: [PATCH 10/14] Remove obsolete poll callout styles There's no element with the `callout` class inside a `polls-show-header` since commit 70a35fbe5. --- app/assets/stylesheets/participation.scss | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss index 0a301284d..2687d64e2 100644 --- a/app/assets/stylesheets/participation.scss +++ b/app/assets/stylesheets/participation.scss @@ -1590,21 +1590,6 @@ .polls-show-header { background: #fafafa; - - .callout { - - &.warning a { - color: $color-warning; - } - - &.primary a { - color: $color-info; - } - - &.alert a { - color: $color-alert; - } - } } .poll-more-info, From 067aa4169a61ceccb36deb83a85813e8210993fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 15 May 2021 21:10:23 +0200 Subject: [PATCH 11/14] Remove obsolete styles for stats menu All menus in the sidebar are "vertical". These styles aren't used since commit b91b766e96b. --- app/assets/stylesheets/participation.scss | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss index 2687d64e2..f453f1371 100644 --- a/app/assets/stylesheets/participation.scss +++ b/app/assets/stylesheets/participation.scss @@ -1859,18 +1859,6 @@ .polls-results-stats { - .sidebar { - - .menu:not(.vertical) { - padding: 0; - - li a { - color: $link; - line-height: $line-height; - } - } - } - table { table-layout: fixed; From 33a40acf741f955ba1d09744bcf6322842453126 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 19 May 2021 22:21:36 +0200 Subject: [PATCH 12/14] Remove obsolete dark heading styles The `.dark-heading` selector isn't used in proposals since commit ac58f3049, and it isn't used anywhere since commit 1b3cdc181. --- app/assets/stylesheets/participation.scss | 30 ----------------------- 1 file changed, 30 deletions(-) diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss index f453f1371..5b6ed3783 100644 --- a/app/assets/stylesheets/participation.scss +++ b/app/assets/stylesheets/participation.scss @@ -1510,36 +1510,6 @@ // 07. Proposals successful // ------------------------- -.dark-heading { - background: #2d3e50; - color: #fff; - - @include breakpoint(medium) { - padding-bottom: $line-height; - } - - p { - - &.title { - color: #ffd200; - } - - &.title-date { - font-size: rem-calc(24); - font-weight: bold; - } - } - - .info { - background: #314253; - padding-top: $line-height; - - @include breakpoint(medium) { - border-top: rem-calc(6) solid #ffd200; - } - } -} - .successful .panel { .icon-successful { From ede45152308cc0adbb3880ef0f67728be85f6146 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 27 May 2021 21:33:18 +0200 Subject: [PATCH 13/14] Remove unused stats styles These classes aren't used since commit e5a2440e9 and the styles were accidentally added when bringing code from Madrid's fork in commit ba67bb2f9. --- app/assets/stylesheets/stats.scss | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/assets/stylesheets/stats.scss b/app/assets/stylesheets/stats.scss index 61b86e1dd..a4ad681a1 100644 --- a/app/assets/stylesheets/stats.scss +++ b/app/assets/stylesheets/stats.scss @@ -201,15 +201,5 @@ table { .success { background: #c1fdd2; } - - .border-left-success { - background: #c1fdd2; - border-left: 2px solid #58ff87; - } - - .border-right-success { - background: #c1fdd2; - border-right: 2px solid #58ff87; - } } } From 7d8a64cb1f01855a7770448180290d4c8eee6ff8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 28 May 2021 02:16:10 +0200 Subject: [PATCH 14/14] Remove unused poll table styles These styles aren't used since commit 6f324c693. --- app/assets/stylesheets/admin.scss | 5 ----- 1 file changed, 5 deletions(-) diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss index 27328ff92..91a80ff92 100644 --- a/app/assets/stylesheets/admin.scss +++ b/app/assets/stylesheets/admin.scss @@ -194,11 +194,6 @@ $table-header: #ecf1f6; &.with-button { line-height: $line-height * 2; - - .button { - @include brand-text; - background: #fff; - } } }