Enables RSpec/ExampleWording and fixes all issues
Both avoiding 'should' and repiting 'it' on the tests description improves reading them and also makes all descriptions consistent. Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
This commit is contained in:
@@ -12,21 +12,21 @@ shared_examples "map validations" do
|
||||
Setting["feature.map"] = nil
|
||||
end
|
||||
|
||||
it "should be valid with a map location" do
|
||||
it "is valid with a map location" do
|
||||
mappable.map_location = build(:map_location)
|
||||
mappable.skip_map = nil
|
||||
|
||||
expect(mappable).to be_valid
|
||||
end
|
||||
|
||||
it "should be valid accepting that the mappable has no map" do
|
||||
it "is valid accepting that the mappable has no map" do
|
||||
mappable.skip_map = "1"
|
||||
mappable.map_location = nil
|
||||
|
||||
expect(mappable).to be_valid
|
||||
end
|
||||
|
||||
it "should be valid when the feature map is deactivated" do
|
||||
it "is valid when the feature map is deactivated" do
|
||||
Setting["feature.map"] = nil
|
||||
|
||||
mappable.map_location = nil
|
||||
@@ -35,14 +35,14 @@ shared_examples "map validations" do
|
||||
expect(mappable).to be_valid
|
||||
end
|
||||
|
||||
it "should not be valid without a map location" do
|
||||
it "is not valid without a map location" do
|
||||
mappable.map_location = nil
|
||||
mappable.skip_map = nil
|
||||
|
||||
expect(mappable).to_not be_valid
|
||||
end
|
||||
|
||||
it "should not be valid without accepting that the mappable has no map" do
|
||||
it "is not valid without accepting that the mappable has no map" do
|
||||
mappable.skip_map = nil
|
||||
|
||||
expect(mappable).to_not be_valid
|
||||
@@ -52,7 +52,7 @@ shared_examples "map validations" do
|
||||
|
||||
describe "cache" do
|
||||
|
||||
it "should expire cache when the map is updated" do
|
||||
it "expires cache when the map is updated" do
|
||||
map_location = create(:map_location)
|
||||
mappable.map_location = map_location
|
||||
mappable.save
|
||||
|
||||
Reference in New Issue
Block a user