From ecdbc4a3f7ed9428c8b369f9beba7292f959d4bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Fuentes?= Date: Fri, 26 Jan 2018 12:06:42 +0100 Subject: [PATCH] added balloting to the list of phases allowed to see all the links --- app/helpers/budgets_helper.rb | 2 +- spec/features/budgets/budgets_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/helpers/budgets_helper.rb b/app/helpers/budgets_helper.rb index 90e986dad..7b48cad1a 100644 --- a/app/helpers/budgets_helper.rb +++ b/app/helpers/budgets_helper.rb @@ -1,7 +1,7 @@ module BudgetsHelper def show_links_to_budget_investments(budget) - ['reviewing_ballots', 'finished'].include? budget.phase + ['balloting', 'reviewing_ballots', 'finished'].include? budget.phase end def heading_name_and_price_html(heading, budget) diff --git a/spec/features/budgets/budgets_spec.rb b/spec/features/budgets/budgets_spec.rb index 00db07feb..d391dc9be 100644 --- a/spec/features/budgets/budgets_spec.rb +++ b/spec/features/budgets/budgets_spec.rb @@ -4,6 +4,7 @@ feature 'Budgets' do let(:budget) { create(:budget) } let(:level_two_user) { create(:user, :level_two) } + let(:allowed_phase_list) { ['balloting', 'reviewing_ballots', 'finished'] } context 'Index' do @@ -84,7 +85,7 @@ feature 'Budgets' do group = create(:budget_group, budget: budget) heading = create(:budget_heading, group: group) - ['reviewing_ballots', 'finished'].each do |phase| + allowed_phase_list.each do |phase| budget.update(phase: phase) visit budgets_path @@ -101,7 +102,6 @@ feature 'Budgets' do group = create(:budget_group, budget: budget) heading = create(:budget_heading, group: group) phases_without_links = ['drafting','informing'] - allowed_phase_list = ['reviewing_ballots', 'finished'] not_allowed_phase_list = Budget::Phase::PHASE_KINDS - phases_without_links - allowed_phase_list