From eb02bc756af0a8e6e7c9fe205d35db5b30791264 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 14 Oct 2020 11:54:05 +0200 Subject: [PATCH] Remove unnecessary constant declarations The `controller` method already creates an anonymous class inheriting from the class we pass it, so there's no need to create yet another subclass. --- spec/controllers/concerns/has_filters_spec.rb | 4 +--- spec/controllers/concerns/has_orders_spec.rb | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/spec/controllers/concerns/has_filters_spec.rb b/spec/controllers/concerns/has_filters_spec.rb index f4cade052..c95531265 100644 --- a/spec/controllers/concerns/has_filters_spec.rb +++ b/spec/controllers/concerns/has_filters_spec.rb @@ -1,9 +1,7 @@ require "rails_helper" describe HasFilters do - class FakeController < ActionController::Base; end - - controller(FakeController) do + controller(ActionController::Base) do include HasFilters has_filters ["all", "pending", "reviewed"], only: :index diff --git a/spec/controllers/concerns/has_orders_spec.rb b/spec/controllers/concerns/has_orders_spec.rb index f37b7c59a..4248e5cd5 100644 --- a/spec/controllers/concerns/has_orders_spec.rb +++ b/spec/controllers/concerns/has_orders_spec.rb @@ -1,9 +1,7 @@ require "rails_helper" describe HasOrders do - class FakeController < ActionController::Base; end - - controller(FakeController) do + controller(ActionController::Base) do include HasOrders has_orders ["created_at", "votes_count", "flags_count", "relevance"], only: :index has_orders ->(c) { ["votes_count", "flags_count"] }, only: :new