From 2545d49aed9e03bc0842489557615929b50a9088 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 20 Sep 2018 17:03:09 +0200 Subject: [PATCH 1/3] Don't allow trailing whitespaces in rubocop Luckily we don't have any trailing whitespaces around, but we might accidentally introduce some. --- .rubocop.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index f697dab0f..2bf64ceb0 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -25,6 +25,9 @@ Layout/IndentationConsistency: Layout/EndOfLine: EnforcedStyle: lf +Layout/TrailingWhitespace: + Enabled: true + Bundler/DuplicatedGem: Enabled: true From ad1e044e0aeb3f5ad0364fe13bb9c399f7b5438d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 21 Sep 2018 01:26:08 +0200 Subject: [PATCH 2/3] Add trailing newline rule to rubocop Just like we're suggesting when we do code reviews and like the rule we've enabled in SCSS-Lint. --- .rubocop.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 2bf64ceb0..549bf8a6c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -25,6 +25,9 @@ Layout/IndentationConsistency: Layout/EndOfLine: EnforcedStyle: lf +Layout/TrailingBlankLines: + Enabled: true + Layout/TrailingWhitespace: Enabled: true From f9bfa450d6fd9ddb003a6d480a92c76ee5fc7d5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 20 Sep 2018 17:42:50 +0200 Subject: [PATCH 3/3] Add percent literal delimiters to rubocop rules As developers agreed upon. --- .rubocop.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 549bf8a6c..93a1a6ce9 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -426,3 +426,6 @@ Security/MarshalLoad: Security/YAMLLoad: Enabled: true + +Style/PercentLiteralDelimiters: + Enabled: true