Do not render "Number of colums" when create a sdg header card

Co-authored-by: Javi Martín <javim@elretirao.net>
This commit is contained in:
taitus
2023-10-25 15:43:00 +02:00
parent 31f42a2c76
commit e9a7731f49
5 changed files with 18 additions and 6 deletions

View File

@@ -11,7 +11,7 @@ class Admin::Widget::Cards::EditComponent < ApplicationComponent
private
def title
if card.header?
if card.header_or_sdg_header?
t("admin.homepage.edit.header_title")
else
t("admin.homepage.edit.card_title")

View File

@@ -11,7 +11,7 @@ class Admin::Widget::Cards::NewComponent < ApplicationComponent
private
def title
if card.header?
if card.header_or_sdg_header?
t("admin.homepage.new.header_title")
else
t("admin.homepage.new.card_title")

View File

@@ -18,4 +18,12 @@ class Widget::Card < ApplicationRecord
def self.body
where(header: false, cardable_id: nil).order(:created_at)
end
def header_or_sdg_header?
header? || sdg_header?
end
def sdg_header?
cardable == WebSection.find_by!(name: "sdg")
end
end

View File

@@ -30,7 +30,7 @@
</div>
<div class="row">
<% unless card.header? %>
<% unless card.header_or_sdg_header? %>
<div class="column">
<%= f.label :columns %>
<p class="help-text"><%= t("admin.site_customization.pages.cards.columns_help") %></p>
@@ -50,7 +50,7 @@
</div>
<div class="column">
<%= f.submit(
t("admin.homepage.#{admin_submit_action(card)}.#{card.header? ? "submit_header" : "submit_card"}"),
t("admin.homepage.#{admin_submit_action(card)}.#{card.header_or_sdg_header? ? "submit_header" : "submit_card"}"),
class: "button success"
) %>
</div>

View File

@@ -21,6 +21,8 @@ describe "SDG homepage configuration" do
visit sdg_management_homepage_path
click_link "Create planning card"
expect(page).to have_field "Number of columns"
within(".translatable-fields") { fill_in "Title", with: "My planning card" }
fill_in "Link URL", with: "/any_path"
click_button "Create card"
@@ -54,9 +56,11 @@ describe "SDG homepage configuration" do
visit sdg_management_homepage_path
click_link "Create header"
expect(page).not_to have_field "Number of columns"
within(".translatable-fields") { fill_in "Title", with: "My header" }
fill_in "Link URL", with: "/any_path"
click_button "Create card"
click_button "Create header"
within(".sdg-header") do
expect(page).to have_content "My header"
@@ -72,7 +76,7 @@ describe "SDG homepage configuration" do
end
within(".translatable-fields") { fill_in "Title", with: "My header update" }
click_button "Save card"
click_button "Save header"
expect(page).to have_content "My header update"
end