From e89d081a479532b6ab0bfedc0ae60a69fd3ed6e9 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Sun, 7 Jan 2018 17:42:59 +0100 Subject: [PATCH] Enable RSpec/PredicateMatcher cop & fix all issues Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher --- .rubocop.yml | 3 +++ spec/models/geozone_spec.rb | 10 +++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index e16503306..6cab21fa8 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -152,4 +152,7 @@ RSpec/NotToNot: Enabled: true RSpec/OverwritingSetup: + Enabled: true + +RSpec/PredicateMatcher: Enabled: true \ No newline at end of file diff --git a/spec/models/geozone_spec.rb b/spec/models/geozone_spec.rb index 69c423f7a..792ae2e0b 100644 --- a/spec/models/geozone_spec.rb +++ b/spec/models/geozone_spec.rb @@ -16,27 +16,27 @@ describe Geozone do let(:geozone) { create(:geozone) } it "is true when not linked to other models" do - expect(geozone.safe_to_destroy?).to be_truthy + expect(geozone).to be_safe_to_destroy end it "is false when already linked to user" do create(:user, geozone: geozone) - expect(geozone.safe_to_destroy?).to be_falsey + expect(geozone).not_to be_safe_to_destroy end it "is false when already linked to proposal" do create(:proposal, geozone: geozone) - expect(geozone.safe_to_destroy?).to be_falsey + expect(geozone).not_to be_safe_to_destroy end it "is false when already linked to spending proposal" do create(:spending_proposal, geozone: geozone) - expect(geozone.safe_to_destroy?).to be_falsey + expect(geozone).not_to be_safe_to_destroy end it "is false when already linked to debate" do create(:debate, geozone: geozone) - expect(geozone.safe_to_destroy?).to be_falsey + expect(geozone).not_to be_safe_to_destroy end end end