From e867135a07c277371126cca5f53bfe30ec545dd6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 15 Mar 2024 21:39:54 +0100
Subject: [PATCH] Always provide the title before writing anything else

This way our views are more consistent.
---
 app/views/budgets/index.html.erb     | 4 ++--
 app/views/budgets/show.html.erb      | 3 ++-
 app/views/pages/custom_page.html.erb | 2 +-
 app/views/proposals/show.html.erb    | 2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/app/views/budgets/index.html.erb b/app/views/budgets/index.html.erb
index c9f677908..aeaee21f1 100644
--- a/app/views/budgets/index.html.erb
+++ b/app/views/budgets/index.html.erb
@@ -1,8 +1,8 @@
-<%= render Shared::BannerComponent.new("budgets") %>
-
 <% provide :title do %><%= t("budgets.index.title") %><% end %>
 <% provide :main_class, "budgets-index" %>
 
+<%= render Shared::BannerComponent.new("budgets") %>
+
 <% content_for :canonical do %>
   <%= render "shared/canonical", href: budgets_url %>
 <% end %>
diff --git a/app/views/budgets/show.html.erb b/app/views/budgets/show.html.erb
index 36ce55708..3b221e4a2 100644
--- a/app/views/budgets/show.html.erb
+++ b/app/views/budgets/show.html.erb
@@ -1,6 +1,7 @@
-<%= render Shared::BannerComponent.new("budgets") %>
 <% provide :title do %><%= @budget.name %><% end %>
 
+<%= render Shared::BannerComponent.new("budgets") %>
+
 <% content_for :canonical do %>
   <%= render "shared/canonical", href: budget_url(@budget, filter: @current_filter) %>
 <% end %>
diff --git a/app/views/pages/custom_page.html.erb b/app/views/pages/custom_page.html.erb
index 3b9674188..6d29f392a 100644
--- a/app/views/pages/custom_page.html.erb
+++ b/app/views/pages/custom_page.html.erb
@@ -1,5 +1,5 @@
-<%= content_for :body_class, "custom-page" %>
 <% provide :title do %><%= @custom_page.title %><% end %>
+<%= content_for :body_class, "custom-page" %>
 
 <div class="row margin-top">
 
diff --git a/app/views/proposals/show.html.erb b/app/views/proposals/show.html.erb
index d3dafbc8f..c0d1f7f53 100644
--- a/app/views/proposals/show.html.erb
+++ b/app/views/proposals/show.html.erb
@@ -1,5 +1,5 @@
-<% preview = false unless local_assigns.has_key? :preview %>
 <% provide :title do %><%= @proposal.title %><% end %>
+<% preview = false unless local_assigns.has_key? :preview %>
 <% content_for :meta_description do %><%= @proposal.summary %><% end %>
 <% provide :social_media_meta_tags do %>
   <%= render "shared/social_media_meta_tags",