From e8195c201db5a5d3f8d5febffa569aee846cb52f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 29 Mar 2024 00:42:48 +0100
Subject: [PATCH] Avoid warnings during initialization

These warnings appear in the logs in the development environment, and,
with Rails 7, the application will crash. When running the tests, they
would appear in the standard error ouput if we set `config.cache_classes
= false` in the test environment but, since that isn't the case, they
don't.

To reproduce these warnings (or the lack of them), start a Rails console
in development and check the log/development.log file.
---
 config/initializers/acts_as_taggable_on.rb       |  8 ++++++--
 .../disable_active_storage_uploads.rb            | 16 +++++++++-------
 config/initializers/globalize.rb                 | 10 ++++++----
 config/initializers/vote_extensions.rb           |  8 ++++++--
 4 files changed, 27 insertions(+), 15 deletions(-)

diff --git a/config/initializers/acts_as_taggable_on.rb b/config/initializers/acts_as_taggable_on.rb
index 7dea4aafc..af1045a80 100644
--- a/config/initializers/acts_as_taggable_on.rb
+++ b/config/initializers/acts_as_taggable_on.rb
@@ -7,6 +7,12 @@ ActsAsTaggableOn.setup do |config|
   # config.base_class = "ApplicationRecord"
 end
 
+Rails.application.reloader.to_prepare do
+  ActsAsTaggableOn::Tag.class_eval do
+    include Graphqlable
+  end
+end
+
 module ActsAsTaggableOn
   Tagging.class_eval do
     after_create :increment_tag_custom_counter
@@ -39,8 +45,6 @@ module ActsAsTaggableOn
       kind == "category"
     end
 
-    include Graphqlable
-
     scope :public_for_api, -> do
       where(
         kind: [nil, "category"],
diff --git a/config/initializers/disable_active_storage_uploads.rb b/config/initializers/disable_active_storage_uploads.rb
index fa5a52a91..f7bf09fb0 100644
--- a/config/initializers/disable_active_storage_uploads.rb
+++ b/config/initializers/disable_active_storage_uploads.rb
@@ -1,11 +1,13 @@
-ActiveStorage::DirectUploadsController.class_eval do
-  def create
-    head :unauthorized
+Rails.application.reloader.to_prepare do
+  ActiveStorage::DirectUploadsController.class_eval do
+    def create
+      head :unauthorized
+    end
   end
-end
 
-ActiveStorage::DiskController.class_eval do
-  def update
-    head :unauthorized
+  ActiveStorage::DiskController.class_eval do
+    def update
+      head :unauthorized
+    end
   end
 end
diff --git a/config/initializers/globalize.rb b/config/initializers/globalize.rb
index 0a63e4d71..9f098a9b0 100644
--- a/config/initializers/globalize.rb
+++ b/config/initializers/globalize.rb
@@ -1,3 +1,9 @@
+Rails.application.reloader.to_prepare do
+  Globalize::ActiveRecord::Translation.class_eval do
+    include SkipValidation
+  end
+end
+
 module Globalize
   module ActiveRecord
     module InstanceMethods
@@ -9,10 +15,6 @@ module Globalize
         end
       end
     end
-
-    class Translation
-      include SkipValidation
-    end
   end
 end
 
diff --git a/config/initializers/vote_extensions.rb b/config/initializers/vote_extensions.rb
index c70392250..080610432 100644
--- a/config/initializers/vote_extensions.rb
+++ b/config/initializers/vote_extensions.rb
@@ -1,6 +1,10 @@
-ActsAsVotable::Vote.class_eval do
-  include Graphqlable
+Rails.application.reloader.to_prepare do
+  ActsAsVotable::Vote.class_eval do
+    include Graphqlable
+  end
+end
 
+ActsAsVotable::Vote.class_eval do
   belongs_to :signature
   belongs_to :budget_investment, foreign_key: "votable_id", class_name: "Budget::Investment"