Increase severity of DynamicFindBy rubocop rule
Back in commit 49e55b4d we lowered its severity because there were a
few false positives. Back then, I didn't realize we could just whitelist
the methods causing false positives.
Thanks taitus for the tip.
This commit is contained in:
@@ -209,7 +209,10 @@ Rails/Date:
|
||||
|
||||
Rails/DynamicFindBy:
|
||||
Enabled: true
|
||||
Severity: refactor
|
||||
Whitelist:
|
||||
- find_by_slug_or_id
|
||||
- find_by_slug_or_id!
|
||||
- find_by_manager_login
|
||||
|
||||
Rails/EnumUniqueness:
|
||||
Enabled: true
|
||||
|
||||
Reference in New Issue
Block a user