From e520a51d573c50113f50f2479b3c2fe0635bb551 Mon Sep 17 00:00:00 2001 From: decabeza Date: Wed, 13 Mar 2019 13:18:53 +0100 Subject: [PATCH] Replace default feature proposals to nil --- db/dev_seeds/settings.rb | 2 +- db/seeds.rb | 2 +- spec/features/proposals_spec.rb | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/db/dev_seeds/settings.rb b/db/dev_seeds/settings.rb index b73bf02e5..b3254ea1a 100644 --- a/db/dev_seeds/settings.rb +++ b/db/dev_seeds/settings.rb @@ -28,7 +28,7 @@ section "Creating Settings" do Setting.create(key: "feature.debates", value: "true") Setting.create(key: "feature.proposals", value: "true") - Setting.create(key: "feature.featured_proposals", value: "true") + Setting.create(key: "feature.featured_proposals", value: nil) Setting.create(key: "feature.polls", value: "true") Setting.create(key: "feature.spending_proposals", value: nil) Setting.create(key: "feature.spending_proposal_features.voting_allowed", value: nil) diff --git a/db/seeds.rb b/db/seeds.rb index 37a64c0ad..c22c747b5 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -66,7 +66,6 @@ Setting["meta_keywords"] = nil # Feature flags Setting['feature.debates'] = true Setting['feature.proposals'] = true -Setting['feature.featured_proposals'] = true Setting['feature.spending_proposals'] = nil Setting['feature.polls'] = true Setting['feature.twitter_login'] = true @@ -84,6 +83,7 @@ Setting['feature.map'] = nil Setting['feature.allow_images'] = true Setting['feature.allow_attached_documents'] = true Setting['feature.help_page'] = true +Setting["feature.featured_proposals"] = nil # Spending proposals feature flags Setting['feature.spending_proposal_features.voting_allowed'] = nil diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb index 8afdf1c05..f185a44ab 100644 --- a/spec/features/proposals_spec.rb +++ b/spec/features/proposals_spec.rb @@ -521,6 +521,7 @@ feature "Proposals" do end scenario "Index do not list retired proposals by default" do + Setting["feature.featured_proposals"] = true create_featured_proposals not_retired = create(:proposal) retired = create(:proposal, retired_at: Time.current) @@ -881,8 +882,10 @@ feature "Proposals" do end scenario "do not show in featured proposals section" do + Setting["feature.featured_proposals"] = true featured_proposal = create(:proposal, :with_confidence_score, cached_votes_up: 100) - archived_proposal = create(:proposal, :archived, :with_confidence_score, cached_votes_up: 10000) + archived_proposal = create(:proposal, :archived, :with_confidence_score, + cached_votes_up: 10000) visit proposals_path