From e3bca85321d91ac73064359bc848e3ecfcb8a6b3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sat, 20 Jun 2020 14:41:35 +0200
Subject: [PATCH] Extract methods in admin menu component

Now that there's no naming confict with the helper method used in the
ProposalsDashboardHelper, we can easily simplify the view, moving the
logic to the Ruby class.
---
 app/components/admin/menu_component.html.erb | 3 +--
 app/components/admin/menu_component.rb       | 8 ++++++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/app/components/admin/menu_component.html.erb b/app/components/admin/menu_component.html.erb
index 4abcb3aa6..8e62a0a1a 100644
--- a/app/components/admin/menu_component.html.erb
+++ b/app/components/admin/menu_component.html.erb
@@ -89,13 +89,12 @@
     </li>
   <% end %>
 
-  <% messages_sections = %w[newsletters emails_download admin_notifications system_emails] %>
   <li class="section-title">
     <a href="#">
       <span class="icon-zip"></span>
       <strong><%= t("admin.menu.messaging_users") %></strong>
     </a>
-    <ul id="messaging_users_menu" <%= "class=is-active" if messages_sections.include?(controller_name) %>>
+    <ul id="messaging_users_menu" <%= "class=is-active" if messages_menu_active? %>>
       <li <%= "class=is-active" if controller_name == "newsletters" %>>
         <%= link_to t("admin.menu.newsletters"), admin_newsletters_path %>
       </li>
diff --git a/app/components/admin/menu_component.rb b/app/components/admin/menu_component.rb
index d9dec8727..6b5fba296 100644
--- a/app/components/admin/menu_component.rb
+++ b/app/components/admin/menu_component.rb
@@ -57,4 +57,12 @@ class Admin::MenuComponent < ApplicationComponent
       controller_name == "local_census_records" ||
         (controller_name == "imports" && controller.class.parent == Admin::LocalCensusRecords)
     end
+
+    def messages_menu_active?
+      messages_sections.include?(controller_name)
+    end
+
+    def messages_sections
+      %w[newsletters emails_download admin_notifications system_emails]
+    end
 end