Improve valuation comments spec to avoid public leaks

Check that on both comment creation and comment reply the public facing
investment page doesn't show them
This commit is contained in:
Bertocq
2018-01-31 16:27:07 +01:00
parent b0eaece981
commit e38e74169e

View File

@@ -69,8 +69,10 @@ feature 'Internal valuation comments on Budget::Investments' do
commentable: investment)
child_comment = create(:comment, :valuation, author: valuator_user, body: "First child",
commentable: investment, parent: parent_comment)
grandchild_comment = create(:comment, :valuation, author: valuator_user, parent: child_comment,
body: "Last child", commentable: investment)
grandchild_comment = create(:comment, :valuation, author: valuator_user,
parent: child_comment,
body: "Last child",
commentable: investment)
visit valuation_budget_budget_investment_path(budget, investment)
@@ -181,8 +183,11 @@ feature 'Internal valuation comments on Budget::Investments' do
click_button 'Publish comment'
within "#comments" do
expect(page).to have_content 'Have you thought about...?'
expect(page).to have_content('Have you thought about...?')
end
visit budget_investment_path(investment.budget, investment)
expect(page).not_to have_content('Have you thought about...?')
end
scenario 'Errors on create without comment text', :js do
@@ -193,7 +198,7 @@ feature 'Internal valuation comments on Budget::Investments' do
expect(page).to have_content "Can't be blank"
end
scenario 'Reply to existing comment', :js do
scenario 'Reply to existing valuation', :js do
comment = create(:comment, :valuation, author: admin_user, commentable: investment)
login_as(valuator_user)
@@ -211,6 +216,9 @@ feature 'Internal valuation comments on Budget::Investments' do
end
expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}", visible: true)
visit budget_investment_path(investment.budget, investment)
expect(page).not_to have_content('It will be done next week.')
end
scenario 'Errors on reply without comment text', :js do