From e655c3c9585fa9c1c6d219e254c8755b3eab7cf7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javier=20Mart=C3=ADn?= Date: Thu, 28 Jun 2018 21:06:02 +0200 Subject: [PATCH] Fix suggestions keyup timeout. The browser was generating one AJAX request per keystroke, ignoring the timeout. The clearTimeout() function needs to be called with the ID value returned by setTimeout(). --- app/assets/javascripts/suggest.js.coffee | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/suggest.js.coffee b/app/assets/javascripts/suggest.js.coffee index 4c5816599..de42fd998 100644 --- a/app/assets/javascripts/suggest.js.coffee +++ b/app/assets/javascripts/suggest.js.coffee @@ -16,8 +16,10 @@ App.Suggest = js_suggest_selector = $this.data('js-suggest') $(js_suggest_selector).html(stHtml) + timer = null + $this.on 'keyup', -> - window.clearTimeout(callback) - window.setTimeout(callback, 1000) + window.clearTimeout(timer) + timer = window.setTimeout(callback, 1000) $this.on 'change', callback