From e35bf97928b8493dcb0ce20c2d9339125fc37c27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 15 Apr 2024 16:41:21 +0200 Subject: [PATCH] Commit transactions when using `return` inside them It doesn't really affect us because we never use `return`, `break` or `throw` inside transactions, since it would be confusing exactly because it wouldn't be 100% clear whether the transaction is committed or not. So we're using the new default value, which will be the only available option in Rails 7.2 [1]. [1] Commit eccc6061f4 in https://github.com/rails/rails --- config/initializers/new_framework_defaults_7_1.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/initializers/new_framework_defaults_7_1.rb b/config/initializers/new_framework_defaults_7_1.rb index e4fba9331..7e0a95ece 100644 --- a/config/initializers/new_framework_defaults_7_1.rb +++ b/config/initializers/new_framework_defaults_7_1.rb @@ -209,7 +209,7 @@ Rails.application.config.active_record.run_after_transaction_callbacks_in_order_ ### # Whether a `transaction` block is committed or rolled back when exited via `return`, `break` or `throw`. #++ -# Rails.application.config.active_record.commit_transaction_on_non_local_return = true +Rails.application.config.active_record.commit_transaction_on_non_local_return = true ### # Controls when to generate a value for has_secure_token declarations.