consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable StaticAttributeDefinedDynamically cop & fix

Browse Source 
rubocop-rspec gem includes cops for FactoryBot like the new
 FactoryBot/StaticAttributeDefinedDynamically to enforce declaring
 static attribute values without a block.

* http://www.rubydoc.info/gems/rubocop-rspec/1.24.0/RuboCop/Cop/RSpec/FactoryBot/StaticAttributeDefinedDynamically
This commit is contained in:
Bertocq
2018-03-07 13:44:54 +01:00
parent d3d9573086
commit e2c42a3c63
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.rubocop.yml
View File

@@ -403,6 +403,9 @@ RSpec/VerifiedDoubles:
RSpec/VoidExpect: RSpec/VoidExpect:
Enabled: true Enabled: true
FactoryBot/StaticAttributeDefinedDynamically:
Enabled: true
Security/Eval: Security/Eval:
Enabled: true Enabled: true

4
spec/factories.rb
View File

@@ -638,13 +638,13 @@ FactoryBot.define do
factory :poll_partial_result, class: 'Poll::PartialResult' do factory :poll_partial_result, class: 'Poll::PartialResult' do
association :question, factory: [:poll_question, :with_answers] association :question, factory: [:poll_question, :with_answers]
association :author, factory: :user association :author, factory: :user
origin { 'web' } origin 'web'
answer { question.question_answers.sample.title } answer { question.question_answers.sample.title }
end end
factory :poll_recount, class: 'Poll::Recount' do factory :poll_recount, class: 'Poll::Recount' do
association :author, factory: :user association :author, factory: :user
origin { 'web' } origin 'web'
end end
factory :officing_residence, class: 'Officing::Residence' do factory :officing_residence, class: 'Officing::Residence' do