From 002d86884bb31a20151dd874ceed156e67e8d640 Mon Sep 17 00:00:00 2001
From: kikito <kikito@gmail.com>
Date: Thu, 3 Sep 2015 11:15:05 +0200
Subject: [PATCH 1/3] Removes the tag selector from debate#index view &
 refactors i18n

---
 app/views/debates/index.html.erb | 40 ++++++++++++++------------------
 config/locales/en.yml            |  7 +++---
 config/locales/es.yml            |  9 +++----
 spec/features/debates_spec.rb    | 30 ------------------------
 4 files changed, 26 insertions(+), 60 deletions(-)

diff --git a/app/views/debates/index.html.erb b/app/views/debates/index.html.erb
index 701110af3..3068f7d52 100644
--- a/app/views/debates/index.html.erb
+++ b/app/views/debates/index.html.erb
@@ -3,30 +3,24 @@
   <div class="filters row">
     <div class="small-9 column">
 
-      <div class="inline-block" >
-        <% if @tag_filter %>
-          <h2>
-            <%= t("debates.index.filter_topic",
-                   number: @debates.size,
-                   topic: @tag_filter) %>
-          </h2>
-        <% else %>
-          <h2><%= t("debates.index.select_topic") %></h2>
-          <form class="inline-block">
-             <select class="js-location-changer" name="tag-filter">
-               <option value="/" selected="selected"><%= t("debates.index.all") %></option>
-               <% @tags.each do |tag| %>
-                 <option value='<%= current_path_with_query_params(tag: tag.name) %>'>
-                   <%= tag.name %>
-                 </option>
-               <% end %>
-             </select>
-          </form>
-        <% end %>
-      </div>
+      <% if @tag_filter %>
+        <div class="inline-block small-8" >
+            <h2>
+              <%= t("debates.index.filter_topic",
+                     count: @debates.size,
+                     topic: @tag_filter) %>
+            </h2>
+        </div>
+      <% end %>
 
-      <div class="inline-block right">
-        <h6 class="inline-block"><%= t("debates.index.select_order") %></h6>
+      <div class="inline-block <%= 'right' if @tag_filter %>">
+        <h6 class="inline-block">
+          <% if @tag_filter %>
+            <%= t("debates.index.select_order") %>
+          <% else %>
+            <%= t("debates.index.select_order_long") %>
+          <% end %>
+        </h6>
         <form class="inline-block">
            <select class="js-location-changer" name="order-selector">
              <% @valid_orders.each do |order| %>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index e5949938c..d83578eea 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -62,13 +62,14 @@ en:
     index:
       create_debate: Create a debate
       select_order: Order by
+      select_order_long: Order debates by
       orders:
         created_at: newest
         total_votes: most voted
         likes: best rated
-      select_topic: "Filter by topic:"
-      filter_topic: "You are seeing %{number} debates with the topic '%{topic}'"
-      all: All
+      filter_topic:
+        one: "You are seeing one debate with the topic '%{topic}'"
+        other: "You are seeing %{count} debates with the topic '%{topic}'"
     debate:
       debate: Debate
       comments:
diff --git a/config/locales/es.yml b/config/locales/es.yml
index 06f46c068..beb19bcf6 100644
--- a/config/locales/es.yml
+++ b/config/locales/es.yml
@@ -62,13 +62,14 @@ es:
     index:
       create_debate: Crea un debate
       select_order: Ordenar por
+      select_order_long: Estás viendo los debates
       orders:
         created_at: "más nuevos"
         total_votes: "más votados"
-        likes: mejor valorados
-      select_topic: "Filtrar por tema:"
-      filter_topic: "Estás viendo %{number} debates con el tema '%{topic}'"
-      all: Todos
+        likes: "mejor valorados"
+      filter_topic:
+        one: "Estás viendo un debate con el tema ''%{topic}''"
+        other: "Estás viendo %{count} debates con el tema '%{topic}'"
     debate:
       debate: Debate
       comments:
diff --git a/spec/features/debates_spec.rb b/spec/features/debates_spec.rb
index f6e07b844..98c848362 100644
--- a/spec/features/debates_spec.rb
+++ b/spec/features/debates_spec.rb
@@ -407,34 +407,4 @@ feature 'Debates' do
       expect(@most_liked_debate.title).to appear_before(@most_voted_debate.title)
     end
   end
-
-  feature 'Debates can be filtered by tags', :js do
-    let!(:debate1) { create(:debate, tag_list: ["Deporte", "Corrupción"]) }
-    let!(:debate2) { create(:debate, tag_list: ["Deporte", "Fiestas populares"]) }
-    let!(:debate3) { create(:debate, tag_list: ["Corrupción", "Fiestas populares"]) }
-
-    scenario 'By default no tag filter is applied' do
-      visit debates_path
-
-      expect(page).to have_content('Filter by topic')
-      expect(page).not_to have_content('with the topic')
-      expect(page).to have_selector('#debates .debate', count: 3)
-    end
-
-    scenario 'Debates are filtered by single tag' do
-      visit debates_path
-
-      select('Deporte', from: 'tag-filter')
-
-      expect(page).not_to have_content('Filter by topic')
-      expect(page).not_to have_select('tag-filter')
-      expect(page).to have_content('with the topic')
-      expect(current_url).to include('tag=Deporte')
-
-      expect(page).to have_selector('#debates .debate', count: 2)
-      expect(page).to_not have_content(debate3.title)
-      expect(page).to have_content(debate1.title)
-      expect(page).to have_content(debate2.title)
-    end
-  end
 end

From e0f8f8d8de3918c442b95c21a2a9882cb1196678 Mon Sep 17 00:00:00 2001
From: kikito <kikito@gmail.com>
Date: Thu, 3 Sep 2015 11:17:21 +0200
Subject: [PATCH 2/3] Removes Debate.search & uses Debate.tagged_by when
 appropriate

Using `params` was wrong here because if given an inexistent tag,
@tag_filter was nil but the debates were still filtered by it (so the
listing and what the page title said were different)
---
 app/controllers/debates_controller.rb |  8 +++++---
 app/models/debate.rb                  |  8 --------
 spec/models/debate_spec.rb            | 15 ---------------
 3 files changed, 5 insertions(+), 26 deletions(-)

diff --git a/app/controllers/debates_controller.rb b/app/controllers/debates_controller.rb
index 451d8e893..019f82688 100644
--- a/app/controllers/debates_controller.rb
+++ b/app/controllers/debates_controller.rb
@@ -1,13 +1,15 @@
 class DebatesController < ApplicationController
-  before_action :parse_order, :parse_tag_filter, only: :index
+  before_action :parse_order, only: :index
+  before_action :parse_tag_filter, only: :index
   before_action :authenticate_user!, except: [:index, :show]
 
   load_and_authorize_resource
   respond_to :html, :js
 
   def index
-    @debates = Debate.search(params).page(params[:page]).for_render.send("sort_by_#{@order}")
-    @tags = ActsAsTaggableOn::Tag.all
+    @debates = Debate.all
+    @debates = @debates.tagged_with(@tag_filter) if @tag_filter
+    @debates = @debates.page(params[:page]).for_render.send("sort_by_#{@order}")
     @tag_cloud = Debate.tag_counts.order('count desc, name asc')
     set_debate_votes(@debates)
   end
diff --git a/app/models/debate.rb b/app/models/debate.rb
index 9c96c812c..c5cacf0f0 100644
--- a/app/models/debate.rb
+++ b/app/models/debate.rb
@@ -35,14 +35,6 @@ class Debate < ActiveRecord::Base
   # Ahoy setup
   visitable # Ahoy will automatically assign visit_id on create
 
-  def self.search(params)
-    if params[:tag]
-      tagged_with(params[:tag])
-    else
-      all
-    end
-  end
-
   def likes
     cached_votes_up
   end
diff --git a/spec/models/debate_spec.rb b/spec/models/debate_spec.rb
index 0378dabab..fc4130354 100644
--- a/spec/models/debate_spec.rb
+++ b/spec/models/debate_spec.rb
@@ -174,21 +174,6 @@ describe Debate do
     end
   end
 
-  describe "#search" do
-    let!(:economy) { create(:debate, tag_list: "Economy") }
-    let!(:health)  { create(:debate, tag_list: "Health")  }
-
-    it "returns debates tagged with params tag" do
-      params = {tag: "Economy"}
-      expect(Debate.search(params)).to match_array([economy])
-    end
-
-    it "returns all debates if no parameters" do
-      params = {}
-      expect(Debate.search(params)).to match_array([economy, health])
-    end
-  end
-
   describe '#default_order' do
     let!(:economy) { create(:debate) }
     let!(:health)  { create(:debate) }

From 3f98ab74b08413de3271058a78800cbce1264331 Mon Sep 17 00:00:00 2001
From: kikito <kikito@gmail.com>
Date: Thu, 3 Sep 2015 11:18:39 +0200
Subject: [PATCH 3/3] Makes tag checking more efficient in Debates#index

1) Only loads the tags if params[:tag] is present
2) Only checks for existence of the tag, instead of loading them all
and getting their names
---
 app/controllers/debates_controller.rb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/controllers/debates_controller.rb b/app/controllers/debates_controller.rb
index 019f82688..730aed21e 100644
--- a/app/controllers/debates_controller.rb
+++ b/app/controllers/debates_controller.rb
@@ -85,8 +85,9 @@ class DebatesController < ApplicationController
     end
 
     def parse_tag_filter
-      valid_tags = ActsAsTaggableOn::Tag.all.map(&:name)
-      @tag_filter = params[:tag] if valid_tags.include?(params[:tag])
+      if params[:tag].present?
+        @tag_filter = params[:tag] if ActsAsTaggableOn::Tag.where(name: params[:tag]).exists?
+      end
     end
 
 end