Merge pull request #5064 from consul/managment_print_budgets

Allow printing investments from any budget in the management interface
This commit is contained in:
Senén Rodero
2023-02-03 15:46:27 +01:00
committed by GitHub
6 changed files with 84 additions and 24 deletions

View File

@@ -0,0 +1,23 @@
<table>
<thead>
<tr>
<th><%= t("management.budgets.table_name") %></th>
<th><%= t("management.budgets.table_phase") %></th>
<th><%= t("management.budgets.table_actions") %></th>
</tr>
</thead>
<tbody>
<% budgets.each do |budget| %>
<tr id="<%= dom_id(budget) %>">
<td><%= budget.name %></td>
<td><%= budget.current_phase.name %></td>
<td align="right">
<%= link_to t("management.budgets.print_investments"),
print_management_budget_investments_path(budget) %>
</td>
</tr>
<% end %>
</tbody>
</table>
<%= paginate budgets %>

View File

@@ -0,0 +1,8 @@
class Management::Budgets::PrintInvestments::TableComponent < ApplicationComponent
attr_reader :budgets
delegate :paginate, to: :helpers
def initialize(budgets)
@budgets = budgets
end
end

View File

@@ -49,10 +49,6 @@ class Management::BaseController < ActionController::Base
I18n.with_locale(session[:locale], &action)
end
def current_budget
Budget.current
end
def clear_password
session[:new_password] = nil
end

View File

@@ -19,7 +19,7 @@ class Management::BudgetsController < Management::BaseController
end
def print_investments
@budget = current_budget
@budgets = Budget.published.order(created_at: :desc).page(params[:page])
end
private

View File

@@ -1,21 +1,9 @@
<h2><%= t("management.budgets.print_investments") %></h2>
<table>
<thead>
<tr>
<th><%= t("management.budgets.table_name") %></th>
<th><%= t("management.budgets.table_phase") %></th>
<th><%= t("management.budgets.table_actions") %></th>
</tr>
</thead>
<tbody>
<tr id="<%= dom_id(@budget) %>">
<td><%= @budget.name %></td>
<td><%= @budget.current_phase.name %></td>
<td align="right">
<%= link_to t("management.budgets.print_investments"),
print_management_budget_investments_path(@budget) %>
</td>
</tr>
</tbody>
</table>
<% if @budgets.any? %>
<%= render Management::Budgets::PrintInvestments::TableComponent.new(@budgets) %>
<% else %>
<div class="callout primary">
<%= t("management.budgets.no_budgets") %>
</div>
<% end %>

View File

@@ -407,6 +407,51 @@ describe "Budget Investments" do
end
context "Printing" do
scenario "Shows all published budgets, last created first" do
finished_budget = create(:budget, :finished)
accepting_budget = create(:budget)
draft_budget = create(:budget, published: false)
login_as_manager(manager)
click_link "Print budget investments"
within "#budget_#{accepting_budget.id}" do
expect(page).to have_link("Print budget investments")
end
within "#budget_#{finished_budget.id}" do
expect(page).to have_link("Print budget investments")
end
expect(page).not_to have_content draft_budget.name
expect(accepting_budget.name).to appear_before(finished_budget.name)
end
scenario "Shows a message when there are no budgets to show" do
login_as_manager(manager)
click_link "Print budget investments"
expect(page).to have_content("There are no active participatory budgets.")
end
scenario "Show pagination when needed" do
allow(Budget).to receive(:default_per_page).and_return(1)
create(:budget, name: "Children")
create(:budget, name: "Sports")
login_as_manager(manager)
click_link "Print budget investments"
expect(page).to have_content("Sports")
within("ul.pagination") do
expect(page).to have_content("1")
expect(page).to have_link("2", href: print_investments_management_budgets_path(page: "2"))
expect(page).not_to have_content("3")
click_link "Next", exact: false
end
expect(page).to have_content("Children")
end
scenario "Printing budget investments" do
16.times { create(:budget_investment, heading: heading) }