consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #5761 from consuldemocracy/officing_voters_lock

Browse Source 
Include voter initialization in officing voters lock
This commit is contained in:
Javi Martín
2024-11-07 11:37:25 +01:00
committed by GitHub
parent e96171541b 45851c74bd
commit df2540d483
2 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/controllers/officing/voters_controller.rb
View File

@@ -13,6 +13,8 @@ class Officing::VotersController < Officing::BaseController
def create def create
@poll = Poll.find(voter_params[:poll_id]) @poll = Poll.find(voter_params[:poll_id])
@user = User.find(voter_params[:user_id]) @user = User.find(voter_params[:user_id])
@user.with_lock do
@voter = Poll::Voter.new(document_type: @user.document_type, @voter = Poll::Voter.new(document_type: @user.document_type,
document_number: @user.document_number, document_number: @user.document_number,
user: @user, user: @user,
@@ -22,7 +24,8 @@ class Officing::VotersController < Officing::BaseController
booth_assignment: current_booth.booth_assignments.find_by(poll: @poll), booth_assignment: current_booth.booth_assignments.find_by(poll: @poll),
officer_assignment: officer_assignment(@poll)) officer_assignment: officer_assignment(@poll))
@user.with_lock { @voter.save! } @voter.save!
end
end end
private private

2
spec/controllers/officing/voters_controller_spec.rb
View File

@@ -15,7 +15,7 @@ describe Officing::VotersController do
voter: { poll_id: poll.id, user_id: user.id }, voter: { poll_id: poll.id, user_id: user.id },
format: :js format: :js
} }
rescue ActionDispatch::IllegalStateError rescue ActionDispatch::IllegalStateError, ActiveRecord::RecordInvalid
end end
end.each(&:join) end.each(&:join)