Add empty SDG index

app/components/sdg/goals/index_component.rb

@@ -0,0 +1,7 @@
+class SDG::Goals::IndexComponent < ApplicationComponent
+  attr_reader :goals
+
+  def initialize(goals)
+    @goals = goals
+  end
+end

app/controllers/sdg/goals_controller.rb

@@ -0,0 +1,9 @@
+class SDG::GoalsController < ApplicationController
+  include FeatureFlags
+  feature_flag :sdg
+  load_and_authorize_resource
+
+  def index
+    @goals = @goals.order(:code)
+  end
+end

app/models/abilities/everyone.rb

@@ -27,6 +27,8 @@ module Abilities
       can [:read], Legislation::Question
       can [:read, :map, :share], Legislation::Proposal
       can [:search, :comments, :read, :create, :new_comment], Legislation::Annotation
+
+      can :read, ::SDG::Goal
     end
   end
 end

app/models/abilities/sdg/manager.rb

@@ -4,7 +4,6 @@ class Abilities::SDG::Manager
   def initialize(user)
     merge Abilities::Common.new(user)
 
-    can :read, ::SDG::Goal
     can :read, ::SDG::Target
   end
 end

app/views/sdg/goals/index.html.erb

@@ -0,0 +1 @@
+<%= render SDG::Goals::IndexComponent.new(@goals) %>

app/views/shared/_subnavigation.html.erb

@@ -42,12 +42,20 @@
                                   accesskey: "5" %>
       </li>
     <% end %>
+    <% if feature?(:sdg) %>
+      <li>
+        <%= layout_menu_link_to t("layouts.header.sdg"),
+                                sdg_goals_path,
+                                controller_path.split("/").first == "sdg",
+                                accesskey: "6" %>
+      </li>
+    <% end %>
     <% if feature?(:help_page) %>
       <li>
         <%= layout_menu_link_to t("layouts.header.help"),
                                 help_path,
                                 current_page?(help_path),
-                                accesskey: "6" %>
+                                accesskey: "7" %>
       </li>
     <% end %>
 

config/locales/en/general.yml

@@ -251,6 +251,7 @@ en:
           other: You have %{count} new notifications
         notifications: Notifications
         no_notifications: "You don't have new notifications"
+      sdg: "SDG"
   notifications:
     index:
       empty_notifications: You don't have new notifications.

config/locales/es/general.yml

@@ -251,6 +251,7 @@ es:
           other: Tienes %{count} notificaciones nuevas
         notifications: Notificaciones
         no_notifications: "No tienes notificaciones nuevas"
+      sdg: "ODS"
   notifications:
     index:
       empty_notifications: No tienes notificaciones nuevas.

config/routes.rb

@@ -21,6 +21,7 @@ Rails.application.routes.draw do
   draw :poll
   draw :proposal
   draw :related_content
+  draw :sdg
   draw :sdg_management
   draw :tag
   draw :user

config/routes/sdg.rb

@@ -0,0 +1,3 @@
+namespace :sdg do
+  resources :goals, only: :index
+end

spec/controllers/sdg/goals_spec.rb

@@ -0,0 +1,13 @@
+require 'rails_helper'
+
+describe SDG::GoalsController do
+  context "featured disabled" do
+    before do
+      Setting["feature.sdg"] = false
+    end
+
+    it "raises feature disabled" do
+      expect { get :index }.to raise_exception(FeatureFlags::FeatureDisabled)
+    end
+  end
+end

spec/models/abilities/administrator_spec.rb

@@ -107,7 +107,6 @@ describe Abilities::Administrator do
   it { should be_able_to(:create, LocalCensusRecords::Import) }
   it { should be_able_to(:show, LocalCensusRecords::Import) }
 
-  it { should be_able_to(:read, SDG::Goal) }
   it { should be_able_to(:read, SDG::Target) }
 
   it { should be_able_to(:read, SDG::Manager) }

spec/models/abilities/common_spec.rb

@@ -305,7 +305,6 @@ describe Abilities::Common do
     it { should be_able_to(:disable_recommendations, Proposal) }
   end
 
-  it { should_not be_able_to(:read, SDG::Goal) }
   it { should_not be_able_to(:read, SDG::Target) }
 
   it { should_not be_able_to(:read, SDG::Manager) }

spec/models/abilities/everyone_spec.rb

@@ -53,7 +53,7 @@ describe Abilities::Everyone do
   it { should_not be_able_to(:summary, create(:legislation_process, :open)) }
   it { should_not be_able_to(:summary, create(:legislation_process, :past, :not_published)) }
 
-  it { should_not be_able_to(:read, SDG::Goal) }
+  it { should be_able_to(:read, SDG::Goal) }
   it { should_not be_able_to(:read, SDG::Target) }
 
   it { should_not be_able_to(:read, SDG::Manager) }

spec/models/abilities/moderator_spec.rb

@@ -109,7 +109,6 @@ describe Abilities::Moderator do
     it { should_not be_able_to(:comment_as_administrator, legislation_question) }
   end
 
-  it { should_not be_able_to(:read, SDG::Goal) }
   it { should_not be_able_to(:read, SDG::Target) }
 
   it { should_not be_able_to(:read, SDG::Manager) }

spec/models/abilities/organization_spec.rb

@@ -23,7 +23,6 @@ describe "Abilities::Organization" do
   it { should be_able_to(:create, Comment) }
   it { should_not be_able_to(:vote, Comment) }
 
-  it { should_not be_able_to(:read, SDG::Goal) }
   it { should_not be_able_to(:read, SDG::Target) }
 
   it { should_not be_able_to(:read, SDG::Manager) }

spec/models/abilities/sdg/manager.rb

@@ -7,7 +7,6 @@ describe "Abilities::SDG::Manager" do
   let(:user) { sdg_manager.user }
   let(:sdg_manager) { create(:sdg_manager) }
 
-  it { should be_able_to(:read, SDG::Goal) }
   it { should be_able_to(:read, SDG::Target) }
 
   it { should_not be_able_to(:read, SDG::Manager) }

spec/models/abilities/valuator_spec.rb

@@ -40,7 +40,6 @@ describe Abilities::Valuator do
     it { should_not be_able_to(:comment_valuation, assigned_investment) }
   end
 
-  it { should_not be_able_to(:read, SDG::Goal) }
   it { should_not be_able_to(:read, SDG::Target) }
 
   it { should_not be_able_to(:read, SDG::Manager) }

spec/system/sdg/goals_spec.rb

@@ -0,0 +1,24 @@
+require "rails_helper"
+
+describe "SDG Goals", :js do
+  before do
+    Setting["feature.sdg"] = true
+  end
+
+  describe "SDG navigation link" do
+    scenario "is not present when the feature is disabled" do
+      Setting["feature.sdg"] = false
+
+      visit root_path
+
+      within("#navigation_bar") { expect(page).not_to have_link "SDG" }
+    end
+
+    scenario "routes to the goals index" do
+      visit root_path
+      within("#navigation_bar") { click_link "SDG" }
+
+      expect(page).to have_current_path sdg_goals_path
+    end
+  end
+end