speeds 10s the test suite by avoiding the creation a few unneeded objects

This commit is contained in:
David Gil
2015-09-15 21:40:50 +02:00
parent fac69770c8
commit ddbc9243e2
3 changed files with 8 additions and 8 deletions

View File

@@ -34,7 +34,7 @@ feature 'Moderate in bulk' do
end end
scenario "select all/none", :js do scenario "select all/none", :js do
create_list(:debate, 20) create_list(:debate, 2)
visit moderation_bulk_path visit moderation_bulk_path

View File

@@ -80,7 +80,7 @@ feature 'Moderate proposals' do
end end
scenario "select all/none", :js do scenario "select all/none", :js do
create_list(:proposal, 20) create_list(:proposal, 2)
visit moderation_proposals_path visit moderation_proposals_path
@@ -98,7 +98,7 @@ feature 'Moderate proposals' do
end end
scenario "remembering page, filter and order" do scenario "remembering page, filter and order" do
create_list(:proposal, 55) create_list(:proposal, 52)
visit moderation_proposals_path(filter: 'all', page: '2', order: 'created_at') visit moderation_proposals_path(filter: 'all', page: '2', order: 'created_at')

View File

@@ -79,7 +79,7 @@ describe Proposal do
describe "#editable?" do describe "#editable?" do
let(:proposal) { create(:proposal) } let(:proposal) { create(:proposal) }
before(:each) {Setting.find_by(key: "max_votes_for_proposal_edit").update(value: 100)} before(:each) {Setting.find_by(key: "max_votes_for_proposal_edit").update(value: 5)}
it "should be true if proposal has no votes yet" do it "should be true if proposal has no votes yet" do
expect(proposal.total_votes).to eq(0) expect(proposal.total_votes).to eq(0)
@@ -87,14 +87,14 @@ describe Proposal do
end end
it "should be true if proposal has less than limit votes" do it "should be true if proposal has less than limit votes" do
create_list(:vote, 91, votable: proposal) create_list(:vote, 4, votable: proposal)
expect(proposal.total_votes).to eq(91) expect(proposal.total_votes).to eq(4)
expect(proposal.editable?).to be true expect(proposal.editable?).to be true
end end
it "should be false if proposal has more than limit votes" do it "should be false if proposal has more than limit votes" do
create_list(:vote, 102, votable: proposal) create_list(:vote, 6, votable: proposal)
expect(proposal.total_votes).to eq(102) expect(proposal.total_votes).to eq(6)
expect(proposal.editable?).to be false expect(proposal.editable?).to be false
end end
end end