From dda79a92243c30bd9e18abcaa1e558809268f6d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Mon, 28 Dec 2020 13:58:17 +0100
Subject: [PATCH] Remove unnecessary advanced search path parameter

We can use the current path as URL instead of passing it every time.
Passing the `page: 1` parameter is also redundant since by default the
index goes to the first page and the search form does not send any page
parameter.
---
 app/views/budgets/investments/index.html.erb | 2 +-
 app/views/debates/index.html.erb             | 2 +-
 app/views/proposals/index.html.erb           | 3 +--
 app/views/shared/_advanced_search.html.erb   | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/app/views/budgets/investments/index.html.erb b/app/views/budgets/investments/index.html.erb
index 023fa1579..1d1da6493 100644
--- a/app/views/budgets/investments/index.html.erb
+++ b/app/views/budgets/investments/index.html.erb
@@ -55,7 +55,7 @@
         </div>
       <% end %>
 
-      <%= render("shared/advanced_search", search_path: budget_investments_path(@budget)) %>
+      <%= render("shared/advanced_search") %>
 
       <% if unfeasible_or_unselected_filter %>
         <ul class="no-bullet submenu">
diff --git a/app/views/debates/index.html.erb b/app/views/debates/index.html.erb
index 26e8a0597..941484b7b 100644
--- a/app/views/debates/index.html.erb
+++ b/app/views/debates/index.html.erb
@@ -52,7 +52,7 @@
         </div>
       </div>
 
-      <%= render "shared/advanced_search", search_path: debates_path(page: 1) %>
+      <%= render "shared/advanced_search" %>
 
       <%= render "shared/order_links", i18n_namespace: "debates.index" %>
 
diff --git a/app/views/proposals/index.html.erb b/app/views/proposals/index.html.erb
index 70462d085..73470cc84 100644
--- a/app/views/proposals/index.html.erb
+++ b/app/views/proposals/index.html.erb
@@ -73,8 +73,7 @@
       <% end %>
 
       <% unless params[:retired].present? || params[:selected].present? %>
-        <%= render "shared/advanced_search",
-                   search_path: proposals_path(page: 1) %>
+        <%= render "shared/advanced_search" %>
       <% end %>
 
       <% unless params[:selected].present? %>
diff --git a/app/views/shared/_advanced_search.html.erb b/app/views/shared/_advanced_search.html.erb
index 5399da18d..95a45c5a5 100644
--- a/app/views/shared/_advanced_search.html.erb
+++ b/app/views/shared/_advanced_search.html.erb
@@ -3,7 +3,7 @@
 </div>
 
 <div class="row advanced-search-form">
-  <%= form_tag search_path, id: "advanced_search_form", method: :get do %>
+  <%= form_tag request.path, id: "advanced_search_form", method: :get do %>
     <div id="js-advanced-search" data-advanced-search-terms="<%= @advanced_search_terms.present? %>" style="display: none">
 
       <div class="small-12 column">