From dcc9a6b561ffb74f8075092d12be98dc1a3b13ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 27 Sep 2019 19:48:23 +0200 Subject: [PATCH] Use symbols instead of constants for behaviours This way we can be more flexible about the factory we can pass as parameter. --- spec/features/budgets/investments_spec.rb | 2 +- spec/features/comments/legislation_questions_spec.rb | 2 +- spec/features/debates_spec.rb | 2 +- spec/features/legislation/proposals_spec.rb | 2 +- spec/features/polls/polls_spec.rb | 2 +- spec/features/proposals_spec.rb | 2 +- spec/shared/features/notifiable_in_app.rb | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb index 7352ff3bf..3bac8bb8d 100644 --- a/spec/features/budgets/investments_spec.rb +++ b/spec/features/budgets/investments_spec.rb @@ -14,7 +14,7 @@ describe "Budget Investments" do "budget_investment_path" context "Concerns" do - it_behaves_like "notifiable in-app", Budget::Investment + it_behaves_like "notifiable in-app", :budget_investment it_behaves_like "relationable", Budget::Investment it_behaves_like "remotely_translatable", :budget_investment, diff --git a/spec/features/comments/legislation_questions_spec.rb b/spec/features/comments/legislation_questions_spec.rb index 8a7ac63f5..69aa7e8e6 100644 --- a/spec/features/comments/legislation_questions_spec.rb +++ b/spec/features/comments/legislation_questions_spec.rb @@ -8,7 +8,7 @@ describe "Commenting legislation questions" do let(:legislation_question) { create :legislation_question, process: process } context "Concerns" do - it_behaves_like "notifiable in-app", Legislation::Question + it_behaves_like "notifiable in-app", :legislation_question end scenario "Index" do diff --git a/spec/features/debates_spec.rb b/spec/features/debates_spec.rb index 921ac93ca..4865b174c 100644 --- a/spec/features/debates_spec.rb +++ b/spec/features/debates_spec.rb @@ -9,7 +9,7 @@ describe "Debates" do end context "Concerns" do - it_behaves_like "notifiable in-app", Debate + it_behaves_like "notifiable in-app", :debate it_behaves_like "relationable", Debate it_behaves_like "remotely_translatable", :debate, diff --git a/spec/features/legislation/proposals_spec.rb b/spec/features/legislation/proposals_spec.rb index 12e8462bf..6e71d8164 100644 --- a/spec/features/legislation/proposals_spec.rb +++ b/spec/features/legislation/proposals_spec.rb @@ -8,7 +8,7 @@ describe "Legislation Proposals" do let(:proposal) { create(:legislation_proposal) } context "Concerns" do - it_behaves_like "notifiable in-app", Legislation::Proposal + it_behaves_like "notifiable in-app", :legislation_proposal end scenario "Only one menu element has 'active' CSS selector" do diff --git a/spec/features/polls/polls_spec.rb b/spec/features/polls/polls_spec.rb index ead8aafaa..ddb0f42cb 100644 --- a/spec/features/polls/polls_spec.rb +++ b/spec/features/polls/polls_spec.rb @@ -3,7 +3,7 @@ require "rails_helper" describe "Polls" do context "Concerns" do - it_behaves_like "notifiable in-app", Poll + it_behaves_like "notifiable in-app", :poll end context "#index" do diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb index 34f903359..8cc3a8561 100644 --- a/spec/features/proposals_spec.rb +++ b/spec/features/proposals_spec.rb @@ -13,7 +13,7 @@ describe "Proposals" do end context "Concerns" do - it_behaves_like "notifiable in-app", Proposal + it_behaves_like "notifiable in-app", :proposal it_behaves_like "relationable", Proposal it_behaves_like "remotely_translatable", :proposal, diff --git a/spec/shared/features/notifiable_in_app.rb b/spec/shared/features/notifiable_in_app.rb index a08bb771c..9d748bf11 100644 --- a/spec/shared/features/notifiable_in_app.rb +++ b/spec/shared/features/notifiable_in_app.rb @@ -1,7 +1,7 @@ -shared_examples "notifiable in-app" do |described_class| +shared_examples "notifiable in-app" do |factory_name| let(:author) { create(:user, :verified) } - let!(:notifiable) { create(model_name(described_class), author: author) } + let!(:notifiable) { create(factory_name, author: author) } scenario "Notification icon is shown" do create(:notification, notifiable: notifiable, user: author)