From dcc838b3d82d3cdc79b317b96b766fbcc0c3cd94 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 30 Jun 2019 05:15:48 +0200 Subject: [PATCH] Make conditions easier to read Combining both the inline and "traditional" `if` styles made the code difficult to read, particularly when compiled to JavaScript. --- app/assets/javascripts/budget_edit_associations.js.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/budget_edit_associations.js.coffee b/app/assets/javascripts/budget_edit_associations.js.coffee index f556f87bc..c10cc75a8 100644 --- a/app/assets/javascripts/budget_edit_associations.js.coffee +++ b/app/assets/javascripts/budget_edit_associations.js.coffee @@ -20,5 +20,5 @@ App.BudgetEditAssociations = click: -> div_id = $(this).data().toggle $(".js-budget-users-list").each -> - if this.id != div_id - $(this).addClass("is-hidden") if !$(this).hasClass("is-hidden") + if this.id != div_id && !$(this).hasClass("is-hidden") + $(this).addClass("is-hidden")