Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe Widget::Feed do
|
||||
|
||||
let(:feed) { build(:widget_feed) }
|
||||
|
||||
context "validations" do
|
||||
@@ -11,9 +10,7 @@ describe Widget::Feed do
|
||||
end
|
||||
|
||||
context "kinds" do
|
||||
|
||||
describe "#proposals" do
|
||||
|
||||
it "returns the most active proposals" do
|
||||
best_proposal = create(:proposal, title: "Best proposal")
|
||||
best_proposal.update_column(:hot_score, 10)
|
||||
@@ -31,11 +28,9 @@ describe Widget::Feed do
|
||||
|
||||
expect(feed.proposals).to eq([best_proposal, medium_proposal, worst_proposal])
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "#debates" do
|
||||
|
||||
it "returns the most active debates" do
|
||||
best_debate = create(:debate, title: "Best debate")
|
||||
best_debate.update_column(:hot_score, 10)
|
||||
@@ -53,7 +48,6 @@ describe Widget::Feed do
|
||||
|
||||
expect(feed.debates).to eq([best_debate, medium_debate, worst_debate])
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "#processes" do
|
||||
@@ -77,7 +71,5 @@ describe Widget::Feed do
|
||||
expect(feed.processes).to be_empty
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user