Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -1,11 +1,9 @@
require "rails_helper"
describe Verification::Letter do
let(:user) { create(:user) }
describe "validations" do
let(:letter) { build(:verification_letter) }
it "is valid" do
@@ -16,21 +14,17 @@ describe Verification::Letter do
letter.user = nil
expect(letter).not_to be_valid
end
end
describe "save" do
it "updates letter_requested" do
letter = build(:verification_letter)
letter.save!
expect(letter.user.letter_requested_at).to be
end
end
describe "#verify" do
let(:letter) { build(:verification_letter, verify: true) }
it "incorrect code" do
@@ -57,5 +51,4 @@ describe Verification::Letter do
expect(letter.errors).to be_empty
end
end
end