Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies

spec/models/verification/letter_spec.rb

@@ -1,11 +1,9 @@
 require "rails_helper"
 
 describe Verification::Letter do
-
   let(:user) { create(:user) }
 
   describe "validations" do
-
     let(:letter) { build(:verification_letter) }
 
     it "is valid" do
@@ -16,21 +14,17 @@ describe Verification::Letter do
       letter.user = nil
       expect(letter).not_to be_valid
     end
-
   end
 
   describe "save" do
-
     it "updates letter_requested" do
       letter = build(:verification_letter)
       letter.save!
       expect(letter.user.letter_requested_at).to be
     end
-
   end
 
   describe "#verify" do
-
     let(:letter) { build(:verification_letter, verify: true) }
 
     it "incorrect code" do
@@ -57,5 +51,4 @@ describe Verification::Letter do
       expect(letter.errors).to be_empty
     end
   end
-
 end

spec/models/verification/management/document_spec.rb

@@ -1,11 +1,9 @@
 require "rails_helper"
 
 describe Verification::Management::Document do
-
   let(:verification_document) { build(:verification_document, document_number: "12345678Z") }
 
   describe "validations" do
-
     it "is valid" do
       expect(verification_document).to be_valid
     end
@@ -31,7 +29,6 @@ describe Verification::Management::Document do
     end
 
     describe "custom validations with RemoteCensus enabled" do
-
       before do
         Setting["feature.remote_census"] = true
         Setting["remote_census.request.date_of_birth"] = "some.value"
@@ -86,7 +83,6 @@ describe Verification::Management::Document do
           expect(verification_document.errors[:date_of_birth]).to include("can't be blank")
         end
       end
-
     end
 
     describe "Allowed Age" do
@@ -130,5 +126,4 @@ describe Verification::Management::Document do
       end
     end
   end
-
 end

spec/models/verification/management/email_spec.rb

@@ -1,7 +1,6 @@
 require "rails_helper"
 
 describe Verification::Management::Email do
-
   describe "#user" do
     subject { Verification::Management::Email.new(document_type: "1", document_number: "1234", email: "inexisting@gmail.com") }
 

spec/models/verification/residence_spec.rb

@@ -1,12 +1,10 @@
 require "rails_helper"
 
 describe Verification::Residence do
-
   let!(:geozone) { create(:geozone, census_code: "01") }
   let(:residence) { build(:verification_residence, document_number: "12345678Z") }
 
   describe "validations" do
-
     it "is valid" do
       expect(residence).to be_valid
     end
@@ -48,7 +46,6 @@ describe Verification::Residence do
       residence.terms_of_service = nil
       expect(residence).not_to be_valid
     end
-
   end
 
   describe "new" do
@@ -64,7 +61,6 @@ describe Verification::Residence do
   end
 
   describe "save" do
-
     it "stores document number, document type, geozone, date of birth and gender" do
       user = create(:user)
       residence.user = user
@@ -79,7 +75,6 @@ describe Verification::Residence do
       expect(user.gender).to eq("male")
       expect(user.geozone).to eq(geozone)
     end
-
   end
 
   describe "tries" do
@@ -111,5 +106,4 @@ describe Verification::Residence do
       )
     end
   end
-
 end

spec/models/verification/sms_spec.rb

@@ -18,5 +18,4 @@ describe Verification::Sms do
     expect(build(:verification_sms, phone: "hello there")).not_to be_valid
     expect(build(:verification_sms, phone: "555; DROP TABLE USERS")).not_to be_valid
   end
-
 end