Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -1,7 +1,6 @@
require "rails_helper"
describe Poll do
let(:poll) { build(:poll) }
describe "Concerns" do
@@ -233,7 +232,6 @@ describe Poll do
expect(Poll.votable_by(user)).to eq [poll]
end
end
describe "#votable_by" do
@@ -344,9 +342,7 @@ describe Poll do
end
context "scopes" do
describe "#not_budget" do
it "returns polls not associated to a budget" do
poll1 = create(:poll)
poll2 = create(:poll)
@@ -355,9 +351,7 @@ describe Poll do
expect(Poll.not_budget).to match_array [poll1, poll2]
expect(Poll.not_budget).not_to include(poll3)
end
end
end
describe "#sort_for_list" do