Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
@@ -240,9 +240,7 @@ describe Dashboard::Action do
|
||||
end
|
||||
|
||||
context "#detect_new_actions_since" do
|
||||
|
||||
describe "No detect new actions" do
|
||||
|
||||
let!(:action) { create(:dashboard_action, :proposed_action, :active, day_offset: 1) }
|
||||
let!(:resource) { create(:dashboard_action, :resource, :active, day_offset: 1) }
|
||||
|
||||
@@ -277,11 +275,9 @@ describe Dashboard::Action do
|
||||
|
||||
expect(Dashboard::Action.detect_new_actions_since(Date.yesterday, proposal)).to eq []
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "Detect new actions when there are news actions actived" do
|
||||
|
||||
context "for published proposals" do
|
||||
let!(:proposal) { create(:proposal) }
|
||||
|
||||
@@ -311,7 +307,6 @@ describe Dashboard::Action do
|
||||
expect(Dashboard::Action.detect_new_actions_since(Date.yesterday,
|
||||
proposal)).not_to include(resource.id)
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
context "for draft proposals" do
|
||||
@@ -343,7 +338,6 @@ describe Dashboard::Action do
|
||||
expect(Dashboard::Action.detect_new_actions_since(Date.yesterday,
|
||||
proposal)).not_to include(resource.id)
|
||||
end
|
||||
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user