Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
@@ -128,7 +128,6 @@ describe "Consul Schema" do
|
||||
|
||||
expect(received_comments).to eq []
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "Proposals" do
|
||||
@@ -196,7 +195,6 @@ describe "Consul Schema" do
|
||||
votes = response["data"]["proposal"]["votes_for"]["edges"]
|
||||
expect(votes.count).to eq(2)
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "Debates" do
|
||||
@@ -408,7 +406,6 @@ describe "Consul Schema" do
|
||||
end
|
||||
|
||||
describe "Proposal notifications" do
|
||||
|
||||
it "does not include proposal notifications for hidden proposals" do
|
||||
visible_proposal = create(:proposal)
|
||||
hidden_proposal = create(:proposal, :hidden)
|
||||
@@ -455,7 +452,6 @@ describe "Consul Schema" do
|
||||
|
||||
expect(received_proposals).to match_array ["Visible"]
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "Tags" do
|
||||
@@ -528,11 +524,9 @@ describe "Consul Schema" do
|
||||
|
||||
expect(received_tags).not_to include("Health")
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "Votes" do
|
||||
|
||||
it "only returns votes from proposals, debates and comments" do
|
||||
create(:proposal, voters: [create(:user)])
|
||||
create(:debate, voters: [create(:user)])
|
||||
@@ -640,7 +634,5 @@ describe "Consul Schema" do
|
||||
|
||||
expect(Time.zone.parse(received_timestamps.first)).to eq Time.zone.parse("2017-12-31 9:00:00")
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user